Fix Triton pointer offsets for large batches#1
Open
HuXinjing wants to merge 1 commit into
Open
Conversation
c83ef10 to
a9bfd1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes large-batch pointer arithmetic in the V2 Triton MaxSim kernels.
For large document batches, pointer offsets such as:
can cross the signed int32 element-offset boundary before GPU memory is exhausted.
With a real ColQwen page shape of
Nd=747, d=320, the limit is about:That caused
flash_maxsim_v2_multiqueryto fail with CUDA illegal memory accessaround 8990 documents even though GPU memory usage was only about 4.5 GiB.
Changes
tl.int64._flash_maxsim_v2_kernel_flash_maxsim_v2_multiquery_kernel_flash_maxsim_v2_mq_dimtile_kernelValidation
Environment:
44 x 320747 x 320flash_maxsim_v2_multiqueryBefore this change:
After this change:
The failure mode after the fix is normal GPU memory exhaustion rather than an
illegal memory access.