Skip to content

feat(web): compact the agent session workspace - #1485

Open
AlekShu wants to merge 2 commits into
mainfrom
feature/agent-page-redesign
Open

AlekShu wants to merge 2 commits into
mainfrom
feature/agent-page-redesign

Conversation

@AlekShu

@AlekShu AlekShu commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

DESCRIPTION

  • Give the agent conversation and message composer the main column. Fold task and runtime details and group secondary commands so reading and replying need less scrolling.

CONFIG

  • No configuration change.

CORE

  • SessionDetail keeps recovery and errors exposed while placing secondary actions in one keyboard-accessible menu.
  • SessionTodo retains one polling owner and shows current work and complete held reasons above expandable history.
  • ConversationView gains responsive reading height without changing paging or live-tail behavior.

FLOW

  • Read and reply in the main column; open task and runtime details on demand. Open Terminal directly or use More for secondary commands.
  • Held tasks and recovery controls remain visible on desktop and phone.

PROMPTS

  • No prompt change.

BEFORE / AFTER

Changed states
State Before edfe3ea After cb302d3
Recovery, desktop Recovery desktop before Recovery desktop after
Recovery, phone Recovery phone before Recovery phone after
Held task, desktop Held task desktop before Held task desktop after
Held task, phone Held task phone before Held task phone after

DECISIONS

Decision Alternative Why
Keep the conversation first and terminal one click away Add a terminal-first workspace Preserve existing terminal behavior within the requested layout scope.
Fold secondary detail and commands Remove capabilities Reduce clutter while retaining access to every existing operation.
Keep full result previews below the conversation Fit previews in the narrow rail Preserve preview readability and existing interactions.

RISKS

  • Low — secondary commands move into More; recovery commands and human blockers remain exposed.

VERIFIED

  • 329 targeted unit checks passed after merging current main at c4f4600, including both managed account dialogs opened from More.
  • Real isolated-browser checks passed at cb302d3: menu keyboard navigation, pause and exposed restore, terminal open/close, disclosures, full held reasons, and desktop/phone layouts.
  • New controls passed rendered contrast checks in both themes. Four matched screenshot pairs use identical fixture state and neutralize temporary path text on both sides.
  • Screenshot pairs retain the original layout evidence. The merge changes only the account action label to Switch account; the unchanged layout and terminal evidence remains applicable.

@spur-code-review

Copy link
Copy Markdown

Code review: pending.

Written by Spur · review-dd92

@spur-ui-tester

Copy link
Copy Markdown

Browser review: pending.

Written by Spur · review-6cb2

@spur-code-review

Copy link
Copy Markdown

Code review: blocked — Required review checks incomplete.

Written by Spur · review-dd92

@spur-ui-tester

Copy link
Copy Markdown

Browser review: blocked — Required review checks incomplete.

Written by Spur · review-6cb2

@spur-ui-tester

Copy link
Copy Markdown

Browser review: pending.

Written by Spur · review-6cb2

@AlekShu

AlekShu commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator Author

Merged current main into the redesign branch and pushed c4f4600. Resolved account-action navigation through More; 329 targeted checks passed. Existing layout evidence is retained for the label-only merge delta.

Written by Spur · spur-c9f4

@spur-code-review

Copy link
Copy Markdown

Code review: pending.

Written by Spur · review-dd92

@spur-ui-tester

Copy link
Copy Markdown

Browser review: pending.

Written by Spur · review-6cb2

@spur-ui-tester

Copy link
Copy Markdown

Browser review: pending.

Written by Spur · review-6cb2

@spur-ui-tester spur-ui-tester Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browser QA Conclusion

Status: APPROVED
Lane: browser
Session: review-6cb2
Attempt: browser-6cb2-c4f4600-delta
H: c4f4600
B: c8fe8c9
Contract digest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702

Conclusion: affected workspace flows passed independent isolated-browser review on desktop and phone. No confirmed attributable defect found.

Checks and scenario evidence:

  • Current-head session detail component checks: 248 passed. Unchanged task component checks: 14 retained passes.
  • Desktop 1440px and phone 390px: menu keyboard navigation and focus return, secondary command access, task/runtime disclosures, full held reason and required human action, current task/history, conversation height/composer, terminal open/close and exposed recovery/error passed.
  • DELTA after main merge: reran managed Claude and Codex account menu/dialog flows at both widths. Correct provider dialog opened; menu closed; Escape closed dialog; no horizontal overflow. Dark/light More text contrast: 14.86:1 / 15.80:1.
  • Captured and inspected workspace, menu, recovery and managed-account screenshots. Actual candidate Next UI rendered with page-scoped API fixtures; unchanged backend/provider execution excluded.

Retention: prior cb302d3 evidence retained for identical task, conversation, disclosure, layout, recovery and terminal boundaries. Current-head change replaces the account menu label and inherits managed-account integration; affected account flows and named session-detail checks rerun.

Interface: semantic UI scope required; all eight changed paths assessed. Original human design/interface authorization was not supplied to this lane; no exemption or retroactive approval claimed.

Exclusions and fixture limits: no CI, full suites, builds, typecheck, lint or E2E suite execution requested. The delta account fixture supplied an invalid empty task payload, producing an unrelated task alert; that alert supplies no task-behavior evidence. Task conclusions use the retained valid current/held/history fixture. Initial invalid lifecycle and conditional-account fixtures were corrected before successful rows; no product defect attributed to fixture failures. Browser proof covers moved controls and dialogs; unchanged account switching/backend operations remain outside scope.

Objections: none

Written by Spur · review-6cb2

Spur review attempt: browser-6cb2-c4f4600-delta
Lane: browser
H: c4f4600
B: c8fe8c9
ContractDigest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Status: APPROVED
Scenario evidence: [{"status":"passed","evidence":"Named component checks: At current H session-detail.test.tsx passed 248 tests; unchanged session-todo.test.tsx retained 14 passed checks from cb302d3. No affected boundary change to SessionTodo."},{"status":"passed","evidence":"Workspace/current-held/history: Desktop 1440px and phone 390px: full human blocker/action readable, current task shown, history disclosures accessible; no horizontal overflow. Retained from cb302d3: SessionTodo and layout markup unchanged by merge."},{"status":"passed","evidence":"Conversation/composer: Desktop and phone conversation max-height and composer access passed at cb302d3; ConversationView and affected layout remain identical at current H."},{"status":"passed","evidence":"Menu/disclosures/recovery: Keyboard Tab/ArrowDown/Home/End/Escape, command presence, folded task/runtime disclosure, terminal URL open/close and exposed Restore/error passed at cb302d3. Unaffected markup and handlers retained; account row rerun separately."},{"status":"passed","evidence":"Managed account delta: Current H: Claude/Codex x desktop/phone More > Switch account opens matching managed provider dialog; menu closes; Escape closes dialog; no overflow. Screenshots inspected."},{"status":"passed","evidence":"Theme delta: Current H: light and dark screenshots inspected; More text contrast 15.80:1 light, 14.86:1 dark after settled theme transition."}]
Coverage: null

Written by Spur · review-6cb2

@spur-ui-tester

Copy link
Copy Markdown

Browser review: approved.

Written by Spur · review-6cb2

@spur-code-review

Copy link
Copy Markdown

Code review: pending.

Written by Spur · review-dd92

@spur-code-review spur-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Conclusion

Status: APPROVED
Lane: code
Session: review-dd92
Attempt: code-dd92-20261118T2
H: c4f4600
B: c8fe8c9
ContractDigest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702

Conclusion: compact workspace changes preserve existing action guards, dialogs, polling and conversation behavior. No confirmed attributable defect found in changed code or direct callers.

Checks: reviewer reran the named session-detail component file at current H. Retained reviewer prior287 passing checks across session-detail, session-todo and conversation-view for unchanged boundaries; final-H session-detail run supersedes its older result. Owner329-check claim remains separate supplementary evidence.

Scenario evidence: inspected changed code and direct callers; verified More action parity and guarded account-dialog integration; retained unchanged task/conversation/recovery boundary evidence. Independently consumed the released browser lane receipt/native review5951989290 and inspected its matching artifact hashes and actual screenshots. Desktop/phone managed Claude/Codex dialogs, menu/disclosures, full held reasons, reading/composer layout and exposed recovery passed with bounded fixture limitations.

Requirements: covered. Semantic UI scope required; assessed all8 changed paths. Supplied original user authority to redesign live covers compact layout, collapsing details and grouping existing commands without capability deletion. This prompt-level authority does not assert authenticated CI consent; aggregate consent/merge gates remain independent.

DELTA: merge inherits current main unchanged; SessionDetail changes only the account label relative to the prior redesign. Current managed account predicate, busy gate and dialog callback match base. SessionTodo and ConversationView unchanged, so prior checks/screenshots retained with boundary-grounded rationale; managed account navigation rerun at current H by browser lane and named component checks.

Exclusions: no CI query, full suite, build, typecheck, lint or E2E suite execution. Browser lane exercised actual candidate UI with page-scoped API fixtures; unchanged account/backend execution excluded. Its account fixture ToDo response was invalid; that alert supplies no task-behavior evidence. Task conclusions use separate retained valid task fixture and reviewer component checks. Prior publication/runtime blocker resolved through released, verified browser evidence; no invented product defect or native approval substitute.

Objections: none

Spur review attempt: code-dd92-20261118T2
Lane: code
H: c4f4600
B: c8fe8c9
ContractDigest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Status: APPROVED
Scenario evidence: [{"status":"passed","evidence":"Reviewer current-H session-detail.test.tsx248 checks pass; managed Claude/Codex More-to-account-dialog regression covered. Retained prior reviewer287 checks across3 named files only for unchanged boundaries."},{"status":"passed","evidence":"Static changed-code/direct-caller review preserves action guards, busy state and handlers; merge account integration matches base. All8 paths interface-assessed; original live redesign authority matches grouped UI scope."},{"status":"passed","evidence":"Verified released browser lane native5951989290/receipt matches pinned identity, current H/B and attempt; inspected matching screenshot hashes and4 managed provider desktop/phone dialogs. Existing UI rendered with scoped API fixtures, no backend behavior claim."},{"status":"passed","evidence":"Retained valid task/menu/recovery/reading layout browser rows across identical component markup; inspected phone full held reason/current/history and desktop menu artifacts plus prior owner4 screenshots. Invalid account-fixture ToDo alert excluded from task conclusions."}]
Coverage: null

Written by Spur · review-dd92

@spur-code-review

Copy link
Copy Markdown

Code review: approved.

Written by Spur · review-dd92

@spur-code-review

Copy link
Copy Markdown

Code review: pending.

Written by Spur · review-dd92

@spur-code-review

Copy link
Copy Markdown

Code review: pending.

Written by Spur · review-dd92

@spur-code-review spur-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Conclusion

Status: APPROVED
Lane: code
Session: review-dd92
Attempt: code-dd92-20261118T3-assessment
H: c4f4600
B: c8fe8c9
ContractDigest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702

Conclusion: no confirmed attributable defect. Retain the independently warranted code verdict and unchanged H/B evidence; this publication reconciles semantic interface representation through the pinned protocol.

Assessment: required. Independently agreed common manifest separates session-todo and session-workspace, retaining the union of both lanes' actual scope and constraints. All eight changed paths assessed. Task/current/held/history/full human reason and action/desktop-phone readability/one polling owner remain covered. Workspace main conversation/composer, responsive reading height, grouped commands, folded details, exposed recovery/errors, every operation/polling behavior, paging/live-tail and direct terminal access remain covered. Before-state wording distinguishes newly added outer task disclosure from per-row audits that were already collapsed. SessionDetail and its browser scenario cover both surfaces; no scope dropped or exemption asserted.

Manifest digest: d67d4254fce8a0b307eb2162657de9c3dfd6081e4d7d1e3dd804016f740b91c8.
Shared representation independently compared with source; each lane retains its own evidence/provenance. Original user live-redesign directive matches compact-layout grouping without capability deletion. No authenticated CI consent inferred.

Checks retained: reviewer current-H SessionDetail248/248 passed65.47s. Prior reviewer287 checks across3 named files retained only for unchanged ToDo/conversation boundaries; current SessionDetail result supersedes its old result. Owner329-check result is separate supplementary evidence. Reviewed changed code/direct callers; action guards, busy gates, existing dialogs, one ToDo polling owner and conversation behavior preserved.

Browser evidence retained: independently verified released browser receipt/native5951989290 and artifact hashes; inspected actual Claude/Codex desktop/phone account-dialog captures plus valid task/menu and owner recovery captures. Same H/B, same UI source; no new runtime row required for manifest-only reconciliation. Browser actual candidate UI used scoped API fixtures; invalid ToDo alert in account fixture excluded from task evidence. Task conclusions use separate valid retained task fixtures and component checks.

Exclusions: no tests rerun for representation-only update; no CI query, full suite, build, typecheck, lint, E2E suite or runtime mutation. Unchanged provider/backend execution excluded. No merge authority or protected-consent claim.

Objections: none

Spur review attempt: code-dd92-20261118T3-assessment
Lane: code
H: c4f4600
B: c8fe8c9
ContractDigest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Status: APPROVED
Scenario evidence: [{"status":"passed","evidence":"Reviewer current-H session-detail.test.tsx248 checks pass; managed Claude/Codex More-to-account-dialog regression covered. Retained prior reviewer287 checks across3 named files only for unchanged boundaries."},{"status":"passed","evidence":"Static changed-code/direct-caller review preserves action guards, busy state and handlers; merge account integration matches base. All8 paths interface-assessed; original live redesign authority matches grouped UI scope."},{"status":"passed","evidence":"Verified released browser lane native5951989290/receipt matches pinned identity, current H/B and attempt; inspected matching screenshot hashes and4 managed provider desktop/phone dialogs. Existing UI rendered with scoped API fixtures, no backend behavior claim."},{"status":"passed","evidence":"Retained valid task/menu/recovery/reading layout browser rows across identical component markup; inspected phone full held reason/current/history and desktop menu artifacts plus prior owner4 screenshots. Invalid account-fixture ToDo alert excluded from task conclusions."},{"status":"passed","evidence":"Manifest-only reconciliation independently preserves required union scope/clauses and all8 changed-path dispositions at unchanged H/B; scenario evidence retained without rerun."}]
Coverage: null

Written by Spur · review-dd92

@spur-code-review

Copy link
Copy Markdown

Code review: approved.

Written by Spur · review-dd92

@spur-ui-tester

Copy link
Copy Markdown

Browser review: pending.

Written by Spur · review-6cb2

@spur-ui-tester

Copy link
Copy Markdown

Browser review: pending.

Written by Spur · review-6cb2

@spur-ui-tester spur-ui-tester Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browser QA Conclusion

Status: APPROVED
Lane: browser
Session: review-6cb2
Attempt: browser-6cb2-manifest-union
H: c4f4600
B: c8fe8c9
Contract digest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702

Conclusion: affected workspace flows passed independent isolated-browser review on desktop and phone. No confirmed attributable defect found. This attempt changes assessment representation only; it retains prior warranted browser verdict and evidence at unchanged H/B.

Checks and scenario evidence:

  • Current-head session detail component checks: 248 passed. Unchanged task component checks: 14 retained passes.
  • Desktop 1440px and phone 390px: menu keyboard navigation and focus return, secondary command access, task/runtime disclosures, full held reason and required human action, current task/history, conversation height/composer, terminal open/close and exposed recovery/error passed.
  • DELTA after main merge: reran managed Claude and Codex account menu/dialog flows at both widths. Correct provider dialog opened; menu closed; Escape closed dialog; no horizontal overflow. Dark/light More text contrast: 14.86:1 / 15.80:1.
  • Captured and inspected workspace, menu, recovery and managed-account screenshots. Actual candidate Next UI rendered with page-scoped API fixtures; unchanged backend/provider execution excluded.

Retention: prior cb302d3 evidence retained for identical task, conversation, disclosure, layout, recovery and terminal boundaries. Current-head change replaces the account menu label and inherits managed-account integration; affected account flows and named session-detail checks rerun.

Interface: semantic UI scope required; all eight changed paths assessed. Prior user prompt UI authority matched through owner handoff and design evidence: compact layout, folds and consolidated actions with capabilities retained. No authenticated CI consent or merge authority supplied. No exemption claimed.

Exclusions and fixture limits: no CI, full suites, builds, typecheck, lint or E2E suite execution requested. The delta account fixture supplied an invalid empty task payload, producing an unrelated task alert; that alert supplies no task-behavior evidence. Task conclusions use the retained valid current/held/history fixture. Initial invalid lifecycle and conditional-account fixtures were corrected before successful rows; no product defect attributed to fixture failures. Browser proof covers moved controls and dialogs; unchanged account switching/backend operations remain outside scope.

Assessment reconciliation: source code, H/B and evidence boundaries unchanged. Independent code/browser published clause union separates session-todo and session-workspace; no clause dropped to force equality. All eight path dispositions retained. The pinned tool hashes assessment into immutable attempt input and offers no assessment-only update; this fresh protocol attempt is necessary to publish the corrected common representation. Earlier browser native 5951989290 remains historical evidence; this attempt does not claim new runtime execution. Independent code T3 Appstate6971730047/native5952149939 was authenticated against the exact same required manifest digest d67d4254fce8a0b307eb2162657de9c3dfd6081e4d7d1e3dd804016f740b91c8 and all eight mappings before this guarded transition.

Objections: none

Written by Spur · review-6cb2

Spur review attempt: browser-6cb2-manifest-union
Lane: browser
H: c4f4600
B: c8fe8c9
ContractDigest: 7c11aa85ed61b2dcdd4d717a45f8a4678cf16df27e1e2c5b219708d24e290702
Status: APPROVED
Scenario evidence: [{"status":"passed","evidence":"Named component checks: At current H session-detail.test.tsx passed 248 tests; unchanged session-todo.test.tsx retained 14 passed checks from cb302d3. No affected boundary change to SessionTodo."},{"status":"passed","evidence":"Workspace/current-held/history: Desktop 1440px and phone 390px: full human blocker/action readable, current task shown, history disclosures accessible; no horizontal overflow. Retained from cb302d3: SessionTodo and layout markup unchanged by merge."},{"status":"passed","evidence":"Conversation/composer: Desktop and phone conversation max-height and composer access passed at cb302d3; ConversationView and affected layout remain identical at current H."},{"status":"passed","evidence":"Menu/disclosures/recovery: Keyboard Tab/ArrowDown/Home/End/Escape, command presence, folded task/runtime disclosure, terminal URL open/close and exposed Restore/error passed at cb302d3. Unaffected markup and handlers retained; account row rerun separately."},{"status":"passed","evidence":"Managed account delta: Current H: Claude/Codex x desktop/phone More > Switch account opens matching managed provider dialog; menu closes; Escape closes dialog; no overflow. Screenshots inspected."},{"status":"passed","evidence":"Theme delta: Current H: light and dark screenshots inspected; More text contrast 15.80:1 light, 14.86:1 dark after settled theme transition."}]
Coverage: null

Written by Spur · review-6cb2

@spur-ui-tester

Copy link
Copy Markdown

Browser review: approved.

Written by Spur · review-6cb2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant