Pr c gke implementation#2
Open
ashishsuneja wants to merge 4 commits into
Open
Conversation
added 4 commits
May 28, 2026 10:27
kubernetes_cluster.py: - Sync methods (CreateNodePool, DeleteNodePool, UpgradeNodePool, UpdateCluster) now wrap their Async counterparts + WaitForOperation instead of raising NotImplementedError — shared logic in base class - Revert StartPolling try/except — separate PR per hubatish feedback kubernetes_management_benchmark.py: - _CleanStartSweep: remove broad except, use guard clause, let it fail - Run(): guard clause style for version resolution
- Replace manual throttle retry loop in CreateNodePoolAsync with vm_util.Retry (max 5 retries, exponential backoff from 10s) - Replace manual ResourceInUseException retry loop in UpdateClusterAsync with vm_util.Retry (max 10 retries, 30s interval) - GetNodePoolNames: logging.warning → raise errors.Resource.GetError - _Delete: remove broad except around DeleteKeyfile — let it fail - _Create: narrow broad except in AZ query to IssueCommandError Addresses hubatish feedback on PR GoogleCloudPlatform#6690 — use vm_util.Retry, less exception handling, let things fail.
- CIDR comment fix: '/16 is narrowest' (not /17) — mahesh8842 comment - UpgradeNodePoolAsync: logging.warning → logging.info for expected fallback to operations list (not an error condition) - UpdateClusterAsync: logging.warning → logging.info for same reason - _GetLatestOperationName: raise errors.Resource.GetError instead of returning empty string after exhausting retries - Remove commented-out HasActiveUpgradeOperations block Addresses hubatish feedback — less logging.warning, let things fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR C: GKE implementation cleanup
fallback to operations list (not an error condition)
returning empty string after exhausting retries
Addresses hubatish feedback — less logging.warning, let things fail.