Feat/nested pagination - #75
Open
andr-ec wants to merge 2 commits into
Open
Conversation
Lets a paginated child collection be fetched alongside its parent in one call:
{ comments: { page: { limit: 10, after: cursor }, fields: [...] } }
Mirrors `Ash.Query.load(query, [comments: Comment |> Ash.Query.page(opts)])`
on the runtime side and the inline pagination shape that the top-level
codegen already emits on the result side.
Relationship metadata gains a `__pagination: "keyset" | "offset" | "mixed"`
discriminator when the destination read action supports pagination.
`ComplexFieldSelection` permits the `{ page, fields }` envelope only on
those relationships, and `InferFieldValue` returns
`NestedPageResult<R, F, P>` for them.
- field_selector: drop redundant `then(fn q -> if ... end)` (use direct
Ash.Query.load), pass `fields` straight through validate_non_empty
(no `|| []`), switch cardinality check to `rel.type in [:has_many,
:many_to_many]` to match the codegen helper, thread `path` through
parse_field_request/classify_nested_request so the args+page
rejection carries the real path, fold the orphan get_fields_value/1
back into its single caller, and trim drive-by comments
- result_processor: collapse the relationship_inner_* pair into a
single unwrap_array_type/2 returning {type, constraints}
- output_formatter: drop ResultProcessor cross-call (it inverted the
pipeline order); mirror the top-level pagination handler exactly,
using format_value with parent-resource type lookup so the wire
shape matches between top-level and nested page reads
- test assertion follows the same atom/string convention as
top-level page output (atoms pass through to the caller)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #74
implements nested pagination
Contributor checklist
Leave anything that you believe does not apply unchecked.