Skip to content

fix: apply each combination part to the whole of what precedes it #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachdaniel merged 1 commit into from
Aug 3, 2026
Merged

fix: apply each combination part to the whole of what precedes it #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/query.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,18 @@ defmodule AshSql.Query do
_domain \\ nil
) do
Enum.reduce(combination_of, subquery(first), fn {type, combination_of}, query ->
# Each part applies to the result of everything before it. Appending
# straight onto the accumulated query would build one flat chain of set
# operations, and SQL's own precedence would then decide the grouping —
# `INTERSECT` binds tighter than `UNION`/`EXCEPT`, so a part could end up
# applied to its predecessor rather than to the whole. Nesting what has
# accumulated keeps the order the parts were given in.
query =
case query do
%Ecto.SubQuery{} -> query
query -> subquery(query)
end

case type do
:union ->
Ecto.Query.union(query, ^combination_of)
Expand Down