Clean up five follow-ups from the mobile hardening pass

[arul28]

Five independent items surfaced while shipping the mobile connection work. Each was verified as a real defect, not a test artifact.

1. Deep-link scope validation (fixes 2 long-failing tests)

testDeepLinkRouterDropsInvalidOptionalHttpsPrScope and testDeepLinkRouterRejectsMalformedCrossMachineScope have been failing on clean main for a while — 7 assertions across both — which masked regressions in every iOS lane this session. The tests were right: the router accepted an accountMachineKey of "not valid" (with a space) and an itemId of "/". Scope components are now rejected when empty, whitespace-bearing, path-separator-bearing, control-character-bearing, or oversized, while staying opaque-ID compatible.

2. Desktop paired-runtime endpoint memory

DesktopPairedMachineEndpointState recorded successes only — the same gap #948 closed on iOS, where dead endpoints get retried forever at the front of the queue. Now mirrors iOS: consecutive-failure tracking, demotion after two failures inside 120s, never removal, reset on success.

3. iOS never told the relay it went to background

AccountService.swift hardcoded appForeground: true, so phone presence only aged out by timeout. Real lifecycle transitions now ride the existing presence path — no new timers.

4. TUI polled lane status every second while streaming

tuiClient/adeApi.ts ran lane.list {includeStatus:true} every 1s while streaming. Now a cheap fast poll with full status every 30s, plus a targeted fetch that keeps the focused lane fresh — the same split #947 built for desktop.

5. Flaky file-service teardown

Intermittent CI failure ENOTEMPTY: rmdir '/tmp/ade-file-service-tree-*/.git' (hit this PR stack once). Teardown is now recursive-forced with bounded retry rather than the assertion being deleted.

Verification

• iOS simulator: full suite 1,083 passed, 0 failed — first clean iOS run of this session
• Desktop endpoint memory: 36 tests · TUI: 113 · action registry: 86 (Node 22)
• File service: 10/10 consecutive runs green
• Xcode hygiene: 35GB free, machine lock held/released, 1.4GB DerivedData deleted

🤖 Generated with Claude Code

  Open in ADE  ·  ade/cleanup-followups-a5aad057 branch  ·  PR #955

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
ade	Ignored		Jul 29, 2026 10:59pm

[coderabbitai]

Warning

Review limit reached

@arul28, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 22 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8f958b8a-65d3-46da-8a09-c87f61be3101

📥 Commits

Reviewing files that changed from the base of the PR and between 5f83ff7 and 82e5f23.

📒 Files selected for processing (20)

• apps/ade-cli/src/tuiClient/__tests__/adeApi.test.ts
• apps/ade-cli/src/tuiClient/__tests__/appPolling.test.tsx
• apps/ade-cli/src/tuiClient/__tests__/remoteLauncher.test.ts
• apps/ade-cli/src/tuiClient/adeApi.ts
• apps/ade-cli/src/tuiClient/app.tsx
• apps/desktop/src/main/services/adeActions/registry.test.ts
• apps/desktop/src/main/services/adeActions/registry.ts
• apps/desktop/src/main/services/files/fileService.test.ts
• apps/desktop/src/main/services/remoteRuntime/pairedRuntimeBootstrap.test.ts
• apps/desktop/src/main/services/remoteRuntime/pairedRuntimeBootstrap.ts
• apps/desktop/src/main/services/remoteRuntime/pairedRuntimeRoutes.test.ts
• apps/desktop/src/main/services/remoteRuntime/pairedRuntimeRoutes.ts
• apps/desktop/src/main/services/remoteRuntime/syncPairedMachineStore.test.ts
• apps/desktop/src/main/services/remoteRuntime/syncPairedMachineStore.ts
• apps/desktop/src/shared/types/pairedRuntime.ts
• apps/ios/ADE/App/ADEApp.swift
• apps/ios/ADE/App/DeepLinkRouter.swift
• apps/ios/ADE/App/DeepLinkURLParsing.swift
• apps/ios/ADE/Services/AccountService.swift
• apps/ios/ADETests/PairingAndDpopTests.swift

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}