Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
142 changes: 71 additions & 71 deletions apps/ade-cli/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/ade-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"test": "vitest run"
},
"dependencies": {
"@anthropic-ai/claude-agent-sdk": "^0.3.202",
"@anthropic-ai/claude-agent-sdk": "^0.3.207",
"@anthropic-ai/sdk": "^0.103.0",
"@cursor/sdk": "^1.0.23",
"@factory/droid-sdk": "^0.2.0",
Expand Down
39 changes: 39 additions & 0 deletions apps/ade-cli/src/services/sync/syncRemoteCommandService.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,45 @@ describe("createSyncRemoteCommandService", () => {
expect(recoverCodexTurn).not.toHaveBeenCalled();
});

it("preserves Claude priority steering and guarded queue cancellation", async () => {
const steer = vi.fn().mockResolvedValue({ steerId: "steer-1", queued: false });
const cancelSteer = vi.fn().mockResolvedValue(undefined);
const { service } = createService({ agentChatService: { steer, cancelSteer } });

await expect(service.execute(makePayload("chat.steer", {
sessionId: "chat-1",
text: "Redirect the active turn.",
dispatchMode: "interrupt",
}))).resolves.toEqual({ ok: true, steerId: "steer-1", queued: false });
expect(steer).toHaveBeenCalledWith({
sessionId: "chat-1",
text: "Redirect the active turn.",
dispatchMode: "interrupt",
});

await expect(service.execute(makePayload("chat.cancelSteer", {
sessionId: "chat-1",
steerId: "steer-1",
requireQueued: true,
}))).resolves.toEqual({ ok: true });
expect(cancelSteer).toHaveBeenCalledWith({
sessionId: "chat-1",
steerId: "steer-1",
requireQueued: true,
});

await expect(service.execute(makePayload("chat.steer", {
sessionId: "chat-1",
text: "Invalid mode.",
dispatchMode: "later",
}))).rejects.toThrow("chat.steer dispatchMode must be 'inline' or 'interrupt'.");
await expect(service.execute(makePayload("chat.cancelSteer", {
sessionId: "chat-1",
steerId: "steer-1",
requireQueued: "yes",
}))).rejects.toThrow("chat.cancelSteer requireQueued must be a boolean.");
});

it("omits non-finite work.resumeCliSession dimensions", async () => {
const { service, ptyService } = createService();

Expand Down
9 changes: 9 additions & 0 deletions apps/ade-cli/src/services/sync/syncRemoteCommandService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2060,17 +2060,26 @@ function parseAgentChatSendArgs(value: Record<string, unknown>): AgentChatSendAr

function parseAgentChatSteerArgs(value: Record<string, unknown>): AgentChatSteerArgs {
const attachments = parseAgentChatFileRefs(value.attachments);
const dispatchMode = value.dispatchMode;
if (dispatchMode !== undefined && dispatchMode !== "inline" && dispatchMode !== "interrupt") {
throw new Error("chat.steer dispatchMode must be 'inline' or 'interrupt'.");
}
return {
sessionId: requireString(value.sessionId, "chat.steer requires sessionId."),
text: requireString(value.text, "chat.steer requires text."),
...(attachments?.length ? { attachments } : {}),
...(dispatchMode ? { dispatchMode } : {}),
};
}

function parseAgentChatCancelSteerArgs(value: Record<string, unknown>): AgentChatCancelSteerArgs {
if (value.requireQueued !== undefined && typeof value.requireQueued !== "boolean") {
throw new Error("chat.cancelSteer requireQueued must be a boolean.");
}
return {
sessionId: requireString(value.sessionId, "chat.cancelSteer requires sessionId."),
steerId: requireString(value.steerId, "chat.cancelSteer requires steerId."),
...(value.requireQueued === true ? { requireQueued: true } : {}),
};
}

Expand Down
Loading