fix(desktop): keep Work chat ticks, menus, and pending model picks consistent - #1201
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Warning Review limit reachedNext included review available in 33 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (49)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Same-branch chats share one history tick, session menus stay glanceable and machine-aware, and a growing composer no longer unpins a thread that was already at the bottom. Co-authored-by: Cursor <cursoragent@cursor.com>
A composer model change was treated as pending whenever it differed from the session, so switching Work chats could skip hydrate and stamp the wrong thread. Scope the deferral to the chat that picked it, gate reasoning/fast/slash commands the same way, and keep Hide sessions in the list pane. Co-authored-by: Cursor <cursoragent@cursor.com>
The live OpenCode stream honors AbortSignal, so a promptAsync rejection must wake the test generator instead of hanging until timeout. Co-authored-by: Cursor <cursoragent@cursor.com>
arul28
force-pushed
the
ade/chat-tick-consistency
branch
from
September 1, 2026 23:47
e5ee56a to
946f060
Compare
arul28
added a commit
that referenced
this pull request
Sep 2, 2026
Share one composer model allowlist between picker props and onModelChange, and drive the session identity menu from a single canRename flag after rebasing onto #1201. Co-authored-by: Cursor <cursoragent@cursor.com>
arul28
added a commit
that referenced
this pull request
Sep 2, 2026
Share one composer model allowlist between picker props and onModelChange, and drive the session identity menu from a single canRename flag after rebasing onto #1201. Co-authored-by: Cursor <cursoragent@cursor.com>
arul28
added a commit
that referenced
this pull request
Sep 2, 2026
…name (#1203) * fix(desktop): send Cursor Cloud model params and keep Cursor's agent name Problem: cloud launches dropped the chosen reasoning/fast-mode params, Send to Cloud ignored CLI drafts, and ADE kept renaming cloud chats while Cursor already named them. Cause: ADE sent only model.id, several title writers treated cloud chats like local sessions, and Cursor one-shots called Agent.create in the host. Change and boundary: fail-closed verified model.params on both create paths, restore the cloud agents panel, route Cursor one-shots through the SDK worker pool, and make Cursor the name authority. Does not bring cloud agents local, and does not fix the 1.2.69 hook.sock path (#1195) or Codex one-shots blocked by a dead local unityMCP. Verification: desktop typecheck and lint clean; 21 affected test files 1879 passed / 1 skipped; CLI typecheck clean; swiftc -parse on touched iOS files. Co-authored-by: Cursor <cursoragent@cursor.com> * ship: apply initial quality revalidation Share one composer model allowlist between picker props and onModelChange, and drive the session identity menu from a single canRename flag after rebasing onto #1201. Co-authored-by: Cursor <cursoragent@cursor.com> * ship: apply post-rebase quality revalidation Fail closed when cloud controls arrive without a model, match requested reasoning and speed values rather than parameter presence, re-read Cursor's name after the first visible turn, and keep iOS rename guards on the initial session. Co-authored-by: Cursor <cursoragent@cursor.com> * ship: iteration 1 — address CodeRabbit catalog, draft, and iOS rename findings Resolve cloud model selection against the probe rows rather than another key's cache, treat blank reasoning as no control, keep composer draft hydration stable across machine switches, and hide iOS Rename from chat summaries that already carry Cursor ownership. Co-authored-by: Cursor <cursoragent@cursor.com> * ship: iteration 2 — give desktop eslint enough heap in CI lint-desktop aborted twice at the default ~4GB Node heap. Raise the lint script to 8GB so the same command can finish on GitHub runners. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Work chats shared one AgentChatPane across switches, so a composer model pick that had not been sent yet could skip hydrate on the next chat and stamp that chat with the wrong model. Session-list hide lived in the chat header, and Jump To Latest still used the old pill copy.
Cause
Pending-model skip compared composer vs session model ids with no session identity, so any mismatch on a different chat looked like an in-progress handoff.
Change and boundary
Pending model, reasoning, Fast Mode, and slash-command fetches stay local until Send and are scoped to the chat that picked them. Hide sessions sits in the session-list toolbar (collapsed recover rail on TerminalsPage). Jump To Latest uses title-case copy.
model_handoffstill records on Send; iOS maps it to a visible system notice; the TUI already prints[model] from → to. Overlay composer/scroll work is not in this PR.Verification
apps/desktopvitest: 665 passed across AgentChatPane, AgentChatMessageList, SessionListPane, TerminalsPage, WorkViewArea, WorkSurfaceHeader, machineIdentitydoes not carry a pending model pick onto another locked chat,keeps reasoning changes local until Send while a model handoff is pending,loads slash commands for the pending model from the lane, not the committed session,keeps model handoff local until the next message is sent)apps/ade-cliformat.test.ts: 71 passedxcrun swiftc -parseon the four iOS event files plus ADETests.swiftAuthored with Cursor Grok 4.6 via ADE.