Skip to content

feat(chat,cli): auto-resume after usage limits, ade triage, attachment overhaul - #1182

Merged
arul28 merged 2 commits into
mainfrom
ade/new-features-audit-7f6566e2
Aug 30, 2026
Merged

feat(chat,cli): auto-resume after usage limits, ade triage, attachment overhaul#1182
arul28 merged 2 commits into
mainfrom
ade/new-features-audit-7f6566e2

Conversation

@arul28

@arul28 arul28 commented Aug 30, 2026

Copy link
Copy Markdown
Owner

ADE   Open in ADE  ·  ade/new-features-audit-7f6566e2 branch  ·  PR #1182


Note

Medium Risk
New HTTP upload surface on the sync listener and remote-controlled filenames demand correct ticket and path containment; triage fetches repair instructions from the network though it fails closed to local copies.

Overview
Adds ade triage, a brain-free CLI path that runs doctor + redacted diagnostics, writes context.md and a repair playbook to a temp bundle, and either launches an installed agent CLI or prints a --agent handoff. Playbook resolution prefers a pinned GitHub fetch (short timeout, no redirects), then packaged/local copies with containment checks, then a built-in minimum; triage context reuses report-issue redaction rules.

Attachment staging moves toward shared limits and path helpers: product cap 50 MB for streamed uploads, legacy 10 MB for in-memory/base64 paths. Paired sync clients can advertise attachmentUploadV1 and mint single-use tickets over chat.createAttachmentUpload, then POST bodies to /ade-attachments/upload on the shared sync HTTP listener (ticket consumed before read, UUID basenames, streaming size cap). Remote chat.copyTempAttachment stays off the sync allowlist; temp saves use safer extensions and shared projectAttachmentsDir staging. Desktop packaging now ships docs/triage beside the CLI.

Agent and quality docs expand AGENTS.md (dev loop, surface checklist, hazards, PR norms), add a quality-review surface-coverage rule, test guidance against wall-clock sleeps, ignore root T3CODE_RESEARCH_*.md, and slim CLAUDE.md to Claude-specific model roles.

TUI keeps parsed Claude plan rate-limit windows when later rate_limit system notices are auto-resume prose. Headless CLI bootstrap wires onAutoResumeOutcome product analytics.

Reviewed by Cursor Bugbot for commit bb7827b. Configure here.

…t overhaul

Three features plus dev-loop hardening:
- Chats arm a durable, cancellable auto-resume when a provider usage limit
  reports a reset time (Claude, Codex); capped at two consecutive arms,
  cancelled by user activity, visible on the recovery card and in Chat info.
- ade triage builds a redacted context + maintained playbook and hands a
  broken install to the user's own agent CLI; --agent mode prints the
  handoff for an already-running agent.
- Attachments: 50MB any-file staging with a path-copy leg (local), a
  ticketed HTTP upload leg (remote, hello_ok attachmentUploadV1), chip UI
  in the composer, and a universal preview modal reusing the Files viewers.
- AGENTS.md surface checklist + hazards + PR house style; quality rule 11
  surface sweep; receipts-not-sleeps test doctrine; ship-lane PR template.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ade Ignored Ignored Preview Aug 30, 2026 1:02am

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 13 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c564d2c1-952e-4ca6-8f2c-59f5bc1700bb

📥 Commits

Reviewing files that changed from the base of the PR and between 445cf6e and 0b7e6ce.

⛔ Files ignored due to path filters (10)
  • AGENTS.md is excluded by !*.md
  • CLAUDE.md is excluded by !*.md
  • docs/ARCHITECTURE.md is excluded by !docs/**
  • docs/features/chat/README.md is excluded by !docs/**
  • docs/features/chat/composer-and-ui.md is excluded by !docs/**
  • docs/features/storage-and-recovery/README.md is excluded by !docs/**
  • docs/features/sync-and-multi-device/README.md is excluded by !docs/**
  • docs/logging.md is excluded by !docs/**
  • docs/playbooks/ship-lane.md is excluded by !docs/**
  • docs/triage/PLAYBOOK.md is excluded by !docs/**
📒 Files selected for processing (87)
  • .agents/skills/quality/SKILL.md
  • .agents/skills/quality/references/ade-review-rules.md
  • .agents/skills/test/SKILL.md
  • .gitignore
  • apps/ade-cli/README.md
  • apps/ade-cli/src/bootstrap.ts
  • apps/ade-cli/src/cli.test.ts
  • apps/ade-cli/src/cli.ts
  • apps/ade-cli/src/commands/reportIssue.ts
  • apps/ade-cli/src/commands/triage.test.ts
  • apps/ade-cli/src/commands/triage.ts
  • apps/ade-cli/src/commands/triageContext.ts
  • apps/ade-cli/src/commands/triageErrors.ts
  • apps/ade-cli/src/commands/triageLaunch.ts
  • apps/ade-cli/src/commands/triagePlaybook.ts
  • apps/ade-cli/src/services/imageAttachment.ts
  • apps/ade-cli/src/services/personalChats/personalChatScope.ts
  • apps/ade-cli/src/services/sync/attachmentUploadService.test.ts
  • apps/ade-cli/src/services/sync/attachmentUploadService.ts
  • apps/ade-cli/src/services/sync/sharedSyncListener.ts
  • apps/ade-cli/src/services/sync/syncHostService.ts
  • apps/ade-cli/src/services/sync/syncRemoteCommandService.test.ts
  • apps/ade-cli/src/services/sync/syncRemoteCommandService.ts
  • apps/ade-cli/src/tuiClient/__tests__/adeApi.test.ts
  • apps/ade-cli/src/tuiClient/adeApi.ts
  • apps/desktop/package.json
  • apps/desktop/resources/ade-cli-help.txt
  • apps/desktop/scripts/regen-ade-cli-help.cjs
  • apps/desktop/scripts/validate-mac-artifacts.mjs
  • apps/desktop/scripts/validate-win-artifacts.mjs
  • apps/desktop/src/main/main.ts
  • apps/desktop/src/main/services/adeActions/registry.test.ts
  • apps/desktop/src/main/services/adeActions/registry.ts
  • apps/desktop/src/main/services/analytics/agentTurnProductAnalytics.ts
  • apps/desktop/src/main/services/analytics/productAnalyticsPolicy.ts
  • apps/desktop/src/main/services/analytics/productAnalyticsService.test.ts
  • apps/desktop/src/main/services/chat/agentChatService.test.ts
  • apps/desktop/src/main/services/chat/agentChatService.ts
  • apps/desktop/src/main/services/chat/attachmentInlineGuard.ts
  • apps/desktop/src/main/services/chat/buildClaudeV2Message.test.ts
  • apps/desktop/src/main/services/chat/buildClaudeV2Message.ts
  • apps/desktop/src/main/services/chat/chatAutoResumeCoordinator.test.ts
  • apps/desktop/src/main/services/chat/chatAutoResumeCoordinator.ts
  • apps/desktop/src/main/services/chat/chatScheduledWorkScheduler.ts
  • apps/desktop/src/main/services/chat/heicAttachmentConverter.ts
  • apps/desktop/src/main/services/chat/workerAttachmentImages.ts
  • apps/desktop/src/main/services/ipc/ipcTimeouts.ts
  • apps/desktop/src/main/services/ipc/registerIpc.ts
  • apps/desktop/src/main/services/ipc/runtimeBridge.ts
  • apps/desktop/src/main/services/remoteRuntime/attachmentUploadClient.test.ts
  • apps/desktop/src/main/services/remoteRuntime/attachmentUploadClient.ts
  • apps/desktop/src/main/services/remoteRuntime/attachmentUploadRoute.test.ts
  • apps/desktop/src/main/services/remoteRuntime/attachmentUploadRoute.ts
  • apps/desktop/src/main/services/remoteRuntime/remoteConnectionPool.ts
  • apps/desktop/src/main/services/remoteRuntime/remoteConnectionService.test.ts
  • apps/desktop/src/main/services/remoteRuntime/remoteConnectionService.ts
  • apps/desktop/src/main/services/storage/storageInsightsService.ts
  • apps/desktop/src/preload/global.d.ts
  • apps/desktop/src/preload/preload.ts
  • apps/desktop/src/renderer/browserMock.ts
  • apps/desktop/src/renderer/components/chat/AgentChatComposer.test.tsx
  • apps/desktop/src/renderer/components/chat/AgentChatComposer.tsx
  • apps/desktop/src/renderer/components/chat/AgentChatMessageList.tsx
  • apps/desktop/src/renderer/components/chat/AgentChatPane.test.tsx
  • apps/desktop/src/renderer/components/chat/AgentChatPane.tsx
  • apps/desktop/src/renderer/components/chat/ChatAttachmentPreviewModal.tsx
  • apps/desktop/src/renderer/components/chat/ChatAttachmentTray.test.tsx
  • apps/desktop/src/renderer/components/chat/ChatAttachmentTray.tsx
  • apps/desktop/src/renderer/components/chat/ProviderFailureRecoveryCard.tsx
  • apps/desktop/src/renderer/components/chat/UserMessageIssueContext.tsx
  • apps/desktop/src/renderer/components/chat/attachmentViewerTarget.test.ts
  • apps/desktop/src/renderer/components/chat/attachmentViewerTarget.ts
  • apps/desktop/src/renderer/components/chat/chatAttachmentStaging.test.ts
  • apps/desktop/src/renderer/components/chat/chatAttachmentStaging.ts
  • apps/desktop/src/renderer/webclient/adapter/agentChat.ts
  • apps/desktop/src/shared/chatAttachmentLimits.ts
  • apps/desktop/src/shared/chatAttachmentStagingFs.test.ts
  • apps/desktop/src/shared/chatAttachmentStagingFs.ts
  • apps/desktop/src/shared/chatAutoResume.test.ts
  • apps/desktop/src/shared/chatAutoResume.ts
  • apps/desktop/src/shared/ipc.ts
  • apps/desktop/src/shared/types/chat.ts
  • apps/desktop/src/shared/types/sync.ts
  • apps/ios/ADE/Views/Work/WorkChatAttachmentTray.swift
  • apps/ios/ADETests/ADETests.swift
  • reference/cli.mdx
  • reference/troubleshooting.mdx
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ade/new-features-audit-7f6566e2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…k services

The pump's 800-iteration budget was worth ~16ms of real time, losing a race
on loaded CI runners and then recycling the runtime it was waiting on; a
failed test's leaked service also wrote into the next test's send ledger.
Patience is now wall-clock (5s) with the fake-tick cap kept; connections
stamp a per-test generation so late sends stop recording.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@arul28
arul28 merged commit 0fbc2bf into main Aug 30, 2026
37 checks passed
@arul28
arul28 deleted the ade/new-features-audit-7f6566e2 branch August 30, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant