Send Droid screenshots as attachment paths over worker IPC - #1179
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Warning Review limit reachedNext included review available in 13 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Inlining screenshot base64 on child.send can stall the Factory turn the same way it stalled Cursor and Pi. The worker now re-opens the attachment file itself. Co-authored-by: Cursor <cursoragent@cursor.com>
The path IPC contract lives on DroidSdkUserImage and the send/pool tests; a production-uncalled validator was extra surface. Co-authored-by: Cursor <cursoragent@cursor.com>
arul28
force-pushed
the
ade/droid-path-image-ipc
branch
from
August 29, 2026 08:08
71dd320 to
0e00a0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ path, mimeType, rootPath }instead of inlined base64 onchild.send, matching Cursor and Pi.readFileWithinRootSecure(10 MB cap). Remote image URLs become prompt text because Droid's stream API has no URL image form.Test plan
droidSdkPool.test.tsasserts send payloads carry paths, notdataagentChatService.test.tssendMessagewith a PNG attachment does not inline PNG magic bytesNote
Medium Risk
Changes how user images reach Droid across process boundaries; wrong path/sandbox reads would break vision turns but avoids IPC stalls from large payloads.
Overview
Droid chat turns no longer inline screenshot base64 on the worker JSON pipe. Main process now builds prompts with the same path-only attachment shape as Pi (
buildPathOnlyWorkerPrompt/buildDroidWorkerPrompt): text without embedded image bytes, plus{ path, mimeType, rootPath }for on-disk attachments. The Droid worker materializes those paths locally viamaterializeWorkerImagesbefore calling@factory/droid-sdk.DroidSdkUserImageis updated to document and type path refs (with optional tiny inlinedatafor tests). Pool and integration tests assert IPC carries paths, notdata, and orchestration tests usevi.waitForwhereawaitDispatchresolves beforesendPrompt. Docs note Pi/Droid URL images become prompt text, not IPC URLs.Reviewed by Cursor Bugbot for commit 71dd320. Configure here.