Repository navigation
test(filters): clamp luminance to avoid threshold rounding failures - #145
Open
wesleydanieell wants to merge 1 commit into
Open
wesleydanieell wants to merge 1 commit into
wesleydanieell wants to merge 1 commit into
Conversation
bearinmindcat
added a commit
that referenced
this pull request
Nov 11, 2026
…white never rounds below zero (#145) Co-authored-by: Wesley <danielwesley266@gmail.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two GPU-based filter tests that fail at a zero cut-off threshold.
The test shader calculates darkness from RGB luminance. Floating-point rounding can produce a value slightly below zero for pure white, causing
step(0.0, dark)to incorrectly discard a pixel. Clamping darkness to the valid[0.0, 1.0]range makes the expected behavior stable.Only the test shader fixture changes; production filter behavior is unchanged.
Testing
cargo fmt --all --checkcargo test -p procraft-core— 712 passed, 0 failed, 15 ignored.