Repository navigation
fix(brushes): generate previews when imported brush previews are blank - #141
Open
wesleydanieell wants to merge 1 commit into
Open
wesleydanieell wants to merge 1 commit into
wesleydanieell wants to merge 1 commit into
Conversation
Some brush files from other apps carry a preview image that is empty. The library took it as the brush's preview and showed nothing, even where the brush paints on the canvas. A blank file preview is now treated as none: the brush draws its own preview from its settings, as an edited brush does. Tested with a blank PNG hung on a round pen.
bearinmindcat
added a commit
that referenced
this pull request
Nov 11, 2026
…preview (#141) Co-authored-by: Wesley <danielwesley266@gmail.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where some imported brushes appeared without a preview in the brush library.
Some brush files contain an embedded preview image that is completely blank. Previously, ProCraft used that image as the brush preview, even when the brush itself could draw normally.
Now, completely blank embedded previews are treated as missing, allowing ProCraft to generate a new preview using the brush's actual settings.
This improves compatibility with brushes imported from other applications without changing their painting behavior.
Testing
Verified with a round pen brush containing an empty PNG preview.