[na] Reject an all-zero cost_model Refs #484 - #541
Merged
Merged
Conversation
An all-zero weight vector is finite and non-negative, but every schedule scores the same, so placement ignores it. Target load and zoned scheduling now fail with a diagnostic that names the four weights. A vector with one positive weight still selects a schedule. Refs #484 Co-authored-by: Arnab Ghosh <ag2583@cornell.edu>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
arniber21
marked this pull request as ready for review
October 1, 2026 17:26
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An all-zero
cost_modelis finite and non-negative, so target load used to accept it and placement treated every schedule as equal. That vector now fails when the target is loaded and when zoned scheduling starts. The diagnostic namesrydberg_stage_weight,movement_time_weight,trap_transfer_weight, andidle_time_weight, and says at least one must be positive.Non-finite and negative weights still fail on the existing checks. A vector with one positive weight still loads and still selects a schedule.
Refs #484