[na] Let movement weight change the chosen schedule - #535
Merged
Merged
Conversation
Stage, idle, and transfer stay positive and fixed. The fixed transfer weight outweighs the stationary partner's idle, so a low movement weight keeps the longer one-atom move and a high movement weight takes the shorter two-atom move. Each verified total is lower under the weights that chose it. Co-authored-by: Arnab Ghosh <ag2583@cornell.edu>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage, idle, and transfer weights stay fixed and positive.
movement_time_weightthen changes which verified one-gate orientation is chosen.With idle and transfer both at 1, the stationary partner's idle swamps the two-transfer savings, so the shorter move wins at every non-negative movement weight. The fixed transfer weight sits just above that idle cost. A movement weight below the longer move's extra time keeps the one-atom orientation. A movement weight above it takes the shorter two-atom move. Each verified total is lower under the weights that chose it.
Refs #484
Test
cargo test -p quon_na --features mlir --lib -- movement_time_weight_selects