feat: Experimental support for --source in topo templates#273
Open
muchzill4 wants to merge 7 commits into
Open
feat: Experimental support for --source in topo templates#273muchzill4 wants to merge 7 commits into
--source in topo templates#273muchzill4 wants to merge 7 commits into
Conversation
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
yejseo01
reviewed
May 27, 2026
Comment on lines
+97
to
+101
|
|
||
| func experimentalFeaturesEnabled() bool { | ||
| const experimentalFeaturesEnvVar = "TOPO_EXPERIMENTAL_FEATURES" | ||
| return strings.TrimSpace(os.Getenv(experimentalFeaturesEnvVar)) == "1" | ||
| } |
Contributor
There was a problem hiding this comment.
should DEVELOPTMENT.md be mentioning this?
Some might say documenting is more maintenance but I think we should document this because of following reasons:
- I don't think people will use it at the top of their memory very well
- Unless we use it, this is not nice for the code base
- it would be good to understand the commitment on using
experimentalFeaturesEnabledby documenting it. Lets say an experimental feature was later made an official feature. There would be extra work on testing and cleaning. Would be good to provide a good use case on whenexperimentalFeaturesEnabledshould be introduced when we already have a PR system with e2e testing.
Contributor
There was a problem hiding this comment.
Maybe the experimentalFeatureEnabled part of the PR should be a separate PR with the DEVELOPMENT.md change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--sourceintopo templateswhenTOPO_EXPERIMENTAL_FEATURES=1TOPO_EXPERIMENTAL_FEATURES=1 \ topo templates \ --source https://raw.githubusercontent.com/arm/topo/refs/heads/main/internal/catalog/data/templates.jsonfile://scheme for easier testing locally