Skip to content

ci: allow read-only text tools in the Claude review and report denied programs - #435

Open
arkavo-com wants to merge 1 commit into
mainfrom
ci/claude-review-allowlist
Open

ci: allow read-only text tools in the Claude review and report denied programs#435
arkavo-com wants to merge 1 commit into
mainfrom
ci/claude-review-allowlist

Conversation

@arkavo-com

Copy link
Copy Markdown
Contributor

Summary

The Claude review on #434 completed with 28 Bash permission denials. Claude Code matches every segment of a pipeline separately, so git diff | grep x | tail -5 is denied unless grep and tail are allowed even though git is.

  • Adds the read-only text-processing set (grep, tail, cut, sort, uniq, tr, awk, xargs, jq, echo, printf, cd, pwd, test, basename, dirname, stat, file, tac, nl, paste, comm, true, false) through the action's settings input. Keeping them out of the one-line --allowedTools string matters: the longer string tripped GitGuardian's generic-password detector on the first attempt (incident 37073880, a false positive on the allowlist itself). settings permissions merge with the CLI list, and none of these entries needs the MCP server discovery that --allowedTools prefixes drive.
  • The diagnostics step now lists the program names of denied Bash calls (first token of each pipeline segment, arguments never echoed) so the heartbeat comment says what to add next time instead of just a count.

Split out of #434 because the action refuses to run a workflow that differs from the default branch, so a workflow edit inside a PR disables the review on that PR.

Test plan

  • YAML parses; the settings JSON parses with 24 entries.
  • After merge: the next PR's heartbeat should report zero denials or name the remaining programs.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FgZDdzrNEtPmbMupyyUTXj

… programs

The reviewer was denied Bash 28 times on PR #434 because pipeline
segments like grep, tail, cut, sort, and xargs were not on the allowlist.
Adds those read-only tools through the action's settings input (the
one-line --allowedTools form trips GitGuardian's generic-password
detector) and makes the diagnostics step list the program names, never
arguments, of denied Bash calls so future gaps show in the heartbeat.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FgZDdzrNEtPmbMupyyUTXj
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Claude Code Review ran on 220f2e4 — result: success.
No readable completion record; review coverage is unverified.

Do not interpret missing findings as a clean review; inspect the execution diagnostics.
Findings are posted as review comments. Run log.

@gitar-bot

gitar-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Allows read-only text tools (grep, tail, cut, sort, uniq, tr, awk, xargs, jq, echo, printf, cd, pwd, test, basename, dirname, stat, file, tac, nl, paste, comm, true, false) in the Claude review workflow via the settings input, and updates diagnostics to report denied program names instead of just a count. No issues found.

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant