Skip to content

Make Compass reviews reduction-first - #280

Merged
ariobarin merged 4 commits into
mainfrom
agent/make-reviews-reduction-first
Jul 24, 2026
Merged

Make Compass reviews reduction-first#280
ariobarin merged 4 commits into
mainfrom
agent/make-reviews-reduction-first

Conversation

@ariobarin

@ariobarin ariobarin commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Compass already values reduction, but the review workflow repeated doctrine without a compact editing test. This distills the audit into five moves and removes 41 net lines from that workflow while preserving verification and authority boundaries.

@ariobarin ariobarin left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-head review at 73b869cce7c117653bd6fa9b91d077aeff13b0d0: no blocking findings. The reduction-first rewrite preserves audience, behavior, evidence, authority, wiring verification, long-running control, and taste-boundary requirements while removing duplicate doctrine. portable checks run 1057 completed successfully, with no existing review comments or unresolved threads. Ready for merge under the user's explicit authority.

@ariobarin
ariobarin marked this pull request as ready for review July 24, 2026 14:44
@ariobarin
ariobarin merged commit 40fb53f into main Jul 24, 2026
5 checks passed
@ariobarin
ariobarin deleted the agent/make-reviews-reduction-first branch July 24, 2026 14:45

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73b869cce7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +74 to +76
For long-running guidance, verify that one logical principal authors control
state, delegates receive reviewed assignments and return evidence, and a fresh
context can resume from anchors plus a checkpoint.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve production-authority checks

When this program is used to review long-running guidance, this reduced checklist no longer asks reviewers to verify that planning authority is explicit before production mutation; it only checks authorship, evidence, and resume behavior, and the later public-mutation sentence does not cover local production edits. That lets a workflow or skill pass this review while allowing implementation to begin from a planning-only assignment, which is a failure mode this repo tells us to flag. Re-add the production-mutation authority check in the long-running guidance review.

AGENTS.md reference: AGENTS.md:L96-L96

Useful? React with 👍 / 👎.

- Does the surface shape judgment instead of enumerating every thought?
- Does it overlap another role, or merely compose with it?
- Would a project or carried route preserve value at lower global cost?
- Does model and effort routing match the current dated profile?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep routing reviews tied to calibration

When reviewing a skill or agent that changes routing, this replacement asks only whether routes match the “current dated profile” but no longer points to local-docs/model-calibration.md or says to update calibration and runtime files together. Because the active Sol, Luna, Terra, GLM, and effort policy is dated and stored outside the runtime files, following this workflow alone can leave a role routed by memory or stale policy instead of current evidence. Restore the calibration source in this check.

AGENTS.md reference: AGENTS.md:L98-L98

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant