fix: handler_test.go 3-value unbundle signature (unbreak main after #116+#118) - #125
Merged
Conversation
#116 (handler tests) and #118 (bundler Rootname refactor) each merged clean against a main that lacked the other, but together they don't compile: the test called h.unbundle with two return values while #118 changed it to three. Discard the new root-name return in the test. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#116 and #118 merged clean individually but are incompatible together — #116's handler test used the old 2-value
unbundle, #118 changed it to 3. This discards the new root-name return in the test sohandlercompiles again. Build/vet/test all green.