Repository navigation
fix(MetricsAuthFilter): Match metrics endpoints on the routed path - #78
Merged
giggsoff merged 1 commit intoOct 27, 2026
Merged
Conversation
…ilter Decide whether a request targets a metrics endpoint from the context that Jetty routed it to, instead of the raw request URI. Only the metrics contexts themselves are exempt: a path under /metrics that no metrics context claims is served by the root context, and the /metrics Jersey context exempts only /executors/prometheus.
giggsoff
changed the title
giggsoff
changed the title
giggsoff
marked this pull request as ready for review
October 22, 2026 07:07
werzerbb
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MetricsAuthFilterdecided on the raw request URI, while Jetty routes on the normalized path.Now the decision uses the routed context (
getContextPath,getServletPath,getPathInfo). Only these skip UI auth:MetricsServlet/PrometheusServletcontexts under/metrics//executors/prometheusin the/metricscontext (PrometheusResource)Verified on a cluster with the Spark Connect UI and the History Server (SPNEGO + TLS):
/metrics/prometheus,/metrics/executors/prometheusand/metrics/applicationHistory/prometheusstay open