fix #3

[tkhabia]

added AccelerometerTap code.

[per1234]

You have forgotten to account for pseudo-acceleration caused by gravity. This causes whichever axis is pointing down to constantly register taps.

---

Please do a Tools > Auto Format if using the Arduino IDE or Ctrl + b if using Arduino Web Editor so that the formatting of your code will be consistent with Arduino's other examples.

[per1234]

Suggested change

	while (!Serial);
	while (!IMU.begin()) {
	Serial.println("Failed to initialize IMU!");
	while (!Serial);
	while (!IMU.begin()) {
	Serial.println("Failed to initialize IMU!");

Remove pointless blank lines.

[per1234]

Suggested change

	float tapThreshold = 0.05 ; //0.05g acceleration in some direction is considered as tap. it can be change for the required sensitivity.
	float tapThreshold = 0.05; //0.05 g acceleration in some direction is considered as tap. it can be changed for the required sensitivity.

[per1234]

Suggested change

	int down = 3 ; // signifing the direction of which is facing downward 1 for x axis ; 2 for y axis ; 3 for z axis;
	int down = 3; // signifying the direction which is facing downward: 1 for x axis; 2 for y axis; 3 for z axis

Fix formatting and typo.

---

Why not make this a char so you can do this:

char down = 'z'; // the axis which is facing downward

[per1234]

Suggested change

	if ((y > tapThreshold || y < -tapThreshold) && down != 2 ) {
	if ((y > tapThreshold || y < -tapThreshold) && down != 2) {

Fix formatting.

[per1234]

Suggested change

	if ((z > tapThreshold || z < -tapThreshold)&& down != 3 ) {
	if ((z > tapThreshold || z < -tapThreshold) && down != 3) {

Fix formatting.

[per1234]

Suggested change

Remove pointless blank lines.

[tkhabia]

do you wish for any other changes?

[MisterAwesome23]

Hey @tkhabia
Thanks for the pull request :)

I have a few queries with the suggested code-

1. How can we detect a tap along all directions? Setting down to a value of 3 (hard-coded) and with this logic, we will not be able to leverage of one of the directions Z axes in this case.

2. I agree with @per1234 of using char for X,Y,Z for direction rather than 1,2,3 since it is more intuitive.

3. Consider adding float tapThreshold and int down in void setup(){} since they're a part of initialization and makes more relevance there.
   More on this- https://forum.arduino.cc/index.php?topic=203395.0

4. If LSM6DS3 provides with positive and negative axes (Not sure on this, CurieIMU does, maybe this will help- https://www.st.com/resource/en/datasheet/lsm6ds3.pdf) direction as well consider adding that as well since it'll be more accurate

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ aentinger
❌ tkhabia
_{You have signed the CLA already but the status is still pending? Let us recheck it.}