Refactor FilesystemType - #4417
Merged
Merged
Conversation
codefiles
commented
Apr 12, 2026
Comment on lines
+134
to
+141
| if fs_type := partition.get('fs_type'): | ||
| fs_type = FilesystemType(fs_type) | ||
| else: | ||
| fs_type = None | ||
|
|
||
| device_partition = PartitionModification( | ||
| status=ModificationStatus(partition['status']), | ||
| fs_type=FilesystemType(partition['fs_type']) if partition.get('fs_type') else None, | ||
| fs_type=fs_type, |
Contributor
Author
There was a problem hiding this comment.
Without this change mypy produces this error:
archinstall/lib/models/device.py:136: error: Argument 1 to "FilesystemType" has incompatible type "str | None"; expected "str" [arg-type]
svartkanin
reviewed
Apr 13, 2026
| MenuItem('ext4', value=FilesystemType.Ext4), | ||
| MenuItem('xfs', value=FilesystemType.Xfs), | ||
| MenuItem('f2fs', value=FilesystemType.F2fs), | ||
| MenuItem(FilesystemType.BTRFS.value, value=FilesystemType.BTRFS), |
Collaborator
There was a problem hiding this comment.
FYI there's a helper function
archinstall/archinstall/tui/ui/menu_item.py
Line 147 in bf9b9cb
it was introduced after this was implemented so one day we can move it :)
svartkanin
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4405