Skip to content

Use Path.copy() #4398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Torxed merged 1 commit into from
Apr 8, 2026
Merged

Use Path.copy() #4398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions archinstall/lib/installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import platform
import re
import shlex
import shutil
import subprocess
import textwrap
import time
Expand Down Expand Up @@ -1483,7 +1482,7 @@ def _add_limine_bootloader(
efi_dir_path.mkdir(parents=True, exist_ok=True)

for file in ('BOOTIA32.EFI', 'BOOTX64.EFI'):
shutil.copy(limine_path / file, efi_dir_path)
(limine_path / file).copy(efi_dir_path)
except Exception as err:
raise DiskError(f'Failed to install Limine in {self.target}{efi_partition.mountpoint}: {err}')

Expand Down Expand Up @@ -1532,7 +1531,7 @@ def _add_limine_bootloader(

try:
# The `limine-bios.sys` file contains stage 3 code.
shutil.copy(limine_path / 'limine-bios.sys', boot_limine_path)
(limine_path / 'limine-bios.sys').copy(boot_limine_path)

# `limine bios-install` deploys the stage 1 and 2 to the
self.arch_chroot(f'limine bios-install {parent_dev_path}', peek_output=True)
Expand Down
3 changes: 1 addition & 2 deletions archinstall/lib/pacman/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import re
from pathlib import Path
from shutil import copy2

from archinstall.lib.models.packages import Repository
from archinstall.lib.pathnames import PACMAN_CONF
Expand Down Expand Up @@ -52,4 +51,4 @@ def apply(self) -> None:

def persist(self) -> None:
if self._repositories and self._config_remote_path:
copy2(PACMAN_CONF, self._config_remote_path)
PACMAN_CONF.copy(self._config_remote_path, preserve_metadata=True)
Loading