Skip to content

Stop installing xorg packages for Wayland profiles #4348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 6 commits into from
Apr 2, 2026
Merged

Stop installing xorg packages for Wayland profiles #4348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b71eeda
Add WaylandProfile to avoid installing xorg packages for Wayland comp…
dylanmtaylor Mar 31, 2026
32b05c2
Refactor: use composition (is_wayland) instead of WaylandProfile inhe…
dylanmtaylor Apr 1, 2026
8d89d1c
Fix X11 profiles to inherit xorg packages from XorgProfile
dylanmtaylor Apr 1, 2026
4504bb3
Style: use consistent multi-line super().__init__ for Wayland profiles
dylanmtaylor Apr 1, 2026
2552153
Refactor: replace is_wayland with DisplayServerType enum
dylanmtaylor Apr 2, 2026
d7b43cb
Remove unnecessary super().packages from desktop profiles
dylanmtaylor Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion archinstall/default_profiles/desktop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from typing import TYPE_CHECKING, Self, override

from archinstall.default_profiles.profile import GreeterType, Profile, ProfileType, SelectResult
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType, SelectResult
from archinstall.lib.menu.helpers import Selection
from archinstall.lib.output import info
from archinstall.lib.profile.profiles_handler import profile_handler
Expand Down Expand Up @@ -95,10 +95,16 @@ def install(self, install_session: Installer) -> None:
# Install common packages for all desktop environments
install_session.add_additional_packages(self.packages)

xorg_installed = False

for profile in self.current_selection:
info(f'Installing profile {profile.name}...')

install_session.add_additional_packages(profile.packages)
install_session.enable_service(profile.services)

if not xorg_installed and profile.display_server == DisplayServerType.Xorg:
install_session.add_additional_packages(['xorg-server', 'xorg-xinit'])
xorg_installed = True

profile.install(install_session)
15 changes: 9 additions & 6 deletions archinstall/default_profiles/desktops/awesome.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,27 @@

from typing import TYPE_CHECKING, override

from archinstall.default_profiles.profile import ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, Profile, ProfileType

if TYPE_CHECKING:
from archinstall.lib.installer import Installer


class AwesomeProfile(XorgProfile):
class AwesomeProfile(Profile):
def __init__(self) -> None:
super().__init__('Awesome', ProfileType.WindowMgr)
super().__init__(
'Awesome',
ProfileType.WindowMgr,
support_gfx_driver=True,
display_server=DisplayServerType.Xorg,
)

@property
@override
def packages(self) -> list[str]:
return super().packages + [
return [
'awesome',
'alacritty',
'xorg-xinit',
'xorg-xrandr',
'xterm',
'feh',
Expand Down
13 changes: 8 additions & 5 deletions archinstall/default_profiles/desktops/bspwm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,20 @@
from typing import override

from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType


class BspwmProfile(XorgProfile):
class BspwmProfile(Profile):
def __init__(self) -> None:
super().__init__('Bspwm', ProfileType.WindowMgr)
super().__init__(
'Bspwm',
ProfileType.WindowMgr,
support_gfx_driver=True,
display_server=DisplayServerType.Xorg,
)

@property
@override
def packages(self) -> list[str]:
# return super().packages + [
return [
'bspwm',
'sxhkd',
Expand Down
12 changes: 8 additions & 4 deletions archinstall/default_profiles/desktops/budgie.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
from typing import override

from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType


class BudgieProfile(XorgProfile):
class BudgieProfile(Profile):
def __init__(self) -> None:
super().__init__('Budgie', ProfileType.DesktopEnv)
super().__init__(
'Budgie',
ProfileType.DesktopEnv,
support_gfx_driver=True,
display_server=DisplayServerType.Xorg,
)

@property
@override
Expand Down
12 changes: 8 additions & 4 deletions archinstall/default_profiles/desktops/cinnamon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
from typing import override

from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType


class CinnamonProfile(XorgProfile):
class CinnamonProfile(Profile):
def __init__(self) -> None:
super().__init__('Cinnamon', ProfileType.DesktopEnv)
super().__init__(
'Cinnamon',
ProfileType.DesktopEnv,
support_gfx_driver=True,
display_server=DisplayServerType.Xorg,
)

@property
@override
Expand Down
12 changes: 8 additions & 4 deletions archinstall/default_profiles/desktops/cosmic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
from typing import override

from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType


class CosmicProfile(XorgProfile):
class CosmicProfile(Profile):
def __init__(self) -> None:
super().__init__('Cosmic', ProfileType.DesktopEnv)
super().__init__(
'Cosmic',
ProfileType.DesktopEnv,
support_gfx_driver=True,
display_server=DisplayServerType.Wayland,
)

@property
@override
Expand Down
12 changes: 8 additions & 4 deletions archinstall/default_profiles/desktops/cutefish.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
from typing import override

from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType


class CutefishProfile(XorgProfile):
class CutefishProfile(Profile):
def __init__(self) -> None:
super().__init__('Cutefish', ProfileType.DesktopEnv)
super().__init__(
'Cutefish',
ProfileType.DesktopEnv,
support_gfx_driver=True,
display_server=DisplayServerType.Xorg,
)

@property
@override
Expand Down
12 changes: 8 additions & 4 deletions archinstall/default_profiles/desktops/deepin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
from typing import override

from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType


class DeepinProfile(XorgProfile):
class DeepinProfile(Profile):
def __init__(self) -> None:
super().__init__('Deepin', ProfileType.DesktopEnv)
super().__init__(
'Deepin',
ProfileType.DesktopEnv,
support_gfx_driver=True,
display_server=DisplayServerType.Xorg,
)

@property
@override
Expand Down
12 changes: 8 additions & 4 deletions archinstall/default_profiles/desktops/enlightenment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
from typing import override

from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType


class EnlightenmentProfile(XorgProfile):
class EnlightenmentProfile(Profile):
def __init__(self) -> None:
super().__init__('Enlightenment', ProfileType.WindowMgr)
super().__init__(
'Enlightenment',
ProfileType.WindowMgr,
support_gfx_driver=True,
display_server=DisplayServerType.Xorg,
)

@property
@override
Expand Down
12 changes: 8 additions & 4 deletions archinstall/default_profiles/desktops/gnome.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
from typing import override

from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType


class GnomeProfile(XorgProfile):
class GnomeProfile(Profile):
def __init__(self) -> None:
super().__init__('GNOME', ProfileType.DesktopEnv)
super().__init__(
'GNOME',
ProfileType.DesktopEnv,
support_gfx_driver=True,
display_server=DisplayServerType.Wayland,
)

@property
@override
Expand Down
12 changes: 8 additions & 4 deletions archinstall/default_profiles/desktops/hyprland.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,21 @@
from typing import override

from archinstall.default_profiles.desktops import SeatAccess
from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType
from archinstall.lib.menu.helpers import Selection
from archinstall.lib.translationhandler import tr
from archinstall.tui.ui.menu_item import MenuItem, MenuItemGroup
from archinstall.tui.ui.result import ResultType


class HyprlandProfile(XorgProfile):
class HyprlandProfile(Profile):
def __init__(self) -> None:
super().__init__('Hyprland', ProfileType.DesktopEnv)
super().__init__(
'Hyprland',
ProfileType.DesktopEnv,
support_gfx_driver=True,
display_server=DisplayServerType.Wayland,
)

self.custom_settings = {'seat_access': None}

Expand Down
12 changes: 8 additions & 4 deletions archinstall/default_profiles/desktops/i3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
from typing import override

from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType


class I3wmProfile(XorgProfile):
class I3wmProfile(Profile):
def __init__(self) -> None:
super().__init__('i3-wm', ProfileType.WindowMgr)
super().__init__(
'i3-wm',
ProfileType.WindowMgr,
support_gfx_driver=True,
display_server=DisplayServerType.Xorg,
)

@property
@override
Expand Down
7 changes: 4 additions & 3 deletions archinstall/default_profiles/desktops/labwc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
from typing import override

from archinstall.default_profiles.desktops import SeatAccess
from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType
from archinstall.lib.menu.helpers import Selection
from archinstall.lib.translationhandler import tr
from archinstall.tui.ui.menu_item import MenuItem, MenuItemGroup
from archinstall.tui.ui.result import ResultType


class LabwcProfile(XorgProfile):
class LabwcProfile(Profile):
def __init__(self) -> None:
super().__init__(
'Labwc',
ProfileType.WindowMgr,
support_gfx_driver=True,
display_server=DisplayServerType.Wayland,
)

self.custom_settings = {'seat_access': None}
Expand Down
12 changes: 8 additions & 4 deletions archinstall/default_profiles/desktops/lxqt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
from typing import override

from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType


class LxqtProfile(XorgProfile):
class LxqtProfile(Profile):
def __init__(self) -> None:
super().__init__('Lxqt', ProfileType.DesktopEnv)
super().__init__(
'Lxqt',
ProfileType.DesktopEnv,
support_gfx_driver=True,
display_server=DisplayServerType.Xorg,
)

# NOTE: SDDM is the only officially supported greeter for LXQt, so unlike other DEs, lightdm is not used here.
# LXQt works with lightdm, but since this is not supported, we will not default to this.
Expand Down
12 changes: 8 additions & 4 deletions archinstall/default_profiles/desktops/mate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
from typing import override

from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType


class MateProfile(XorgProfile):
class MateProfile(Profile):
def __init__(self) -> None:
super().__init__('Mate', ProfileType.DesktopEnv)
super().__init__(
'Mate',
ProfileType.DesktopEnv,
support_gfx_driver=True,
display_server=DisplayServerType.Xorg,
)

@property
@override
Expand Down
7 changes: 4 additions & 3 deletions archinstall/default_profiles/desktops/niri.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
from typing import override

from archinstall.default_profiles.desktops import SeatAccess
from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType
from archinstall.lib.menu.helpers import Selection
from archinstall.lib.translationhandler import tr
from archinstall.tui.ui.menu_item import MenuItem, MenuItemGroup
from archinstall.tui.ui.result import ResultType


class NiriProfile(XorgProfile):
class NiriProfile(Profile):
def __init__(self) -> None:
super().__init__(
'Niri',
ProfileType.WindowMgr,
support_gfx_driver=True,
display_server=DisplayServerType.Wayland,
)

self.custom_settings = {'seat_access': None}
Expand Down
12 changes: 8 additions & 4 deletions archinstall/default_profiles/desktops/plasma.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
from typing import override

from archinstall.default_profiles.profile import GreeterType, ProfileType
from archinstall.default_profiles.xorg import XorgProfile
from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType


class PlasmaProfile(XorgProfile):
class PlasmaProfile(Profile):
def __init__(self) -> None:
super().__init__('KDE Plasma', ProfileType.DesktopEnv)
super().__init__(
'KDE Plasma',
ProfileType.DesktopEnv,
support_gfx_driver=True,
display_server=DisplayServerType.Wayland,
)

@property
@override
Expand Down
Loading
Loading