Skip to content

Remove support for NTFS root file system - #4279

Merged
svartkanin merged 2 commits into
archlinux:masterfrom
codefiles:rmv-ntfs-root-support
Mar 3, 2026
Merged

Remove support for NTFS root file system#4279
svartkanin merged 2 commits into
archlinux:masterfrom
codefiles:rmv-ntfs-root-support

Conversation

@codefiles

Copy link
Copy Markdown
Contributor

Closes #4276

Fat12 = 'fat12'
Fat16 = 'fat16'
Fat32 = 'fat32'
Ntfs = 'ntfs'

@codefiles codefiles Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing partitions with NTFS file systems would not display as ntfs in disk menus if the line Ntfs = 'ntfs' above was removed, right?

def _determine_fs_type(
self,
partition: Partition,
lsblk_info: LsblkInfo | None = None,
) -> FilesystemType | None:
try:
if partition.fileSystem:
if partition.fileSystem.type == FilesystemType.LinuxSwap.parted_value:
return FilesystemType.LinuxSwap
return FilesystemType(partition.fileSystem.type)
elif lsblk_info is not None:
return FilesystemType(lsblk_info.fstype) if lsblk_info.fstype else None
return None
except ValueError:
debug(f'Could not determine the filesystem: {partition.fileSystem}')
return None

Comment thread archinstall/lib/installer.py Outdated
kernel_parameters.append('rw')

kernel_parameters.append(f'rootfstype={root.safe_fs_type.fs_type_mount}')
kernel_parameters.append(f'rootfstype={root.safe_fs_type}')

@svartkanin svartkanin Mar 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this format it as

rootfstype=FilesystemType.Ext4

The fs_type_mount function was also handling Fat32 type respectively with vfat

@codefiles codefiles Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this format it as

rootfstype=FilesystemType.Ext4

Yes, that is a mistake. I'm glad you caught that.

The fs_type_mount function was also handling Fat32 type respectively with vfat

The fs_type_mount function was only really being used for the rootfstype kernel parameter. FAT32 should not be used as a root file system so removing this should be fine.

@svartkanin
svartkanin merged commit 64567a7 into archlinux:master Mar 3, 2026
9 checks passed
@codefiles
codefiles deleted the rmv-ntfs-root-support branch March 3, 2026 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove support for NTFS root file system

2 participants