Remove support for NTFS root file system - #4279
Conversation
| Fat12 = 'fat12' | ||
| Fat16 = 'fat16' | ||
| Fat32 = 'fat32' | ||
| Ntfs = 'ntfs' |
There was a problem hiding this comment.
Existing partitions with NTFS file systems would not display as ntfs in disk menus if the line Ntfs = 'ntfs' above was removed, right?
archinstall/archinstall/lib/disk/device_handler.py
Lines 142 to 158 in b809c84
| kernel_parameters.append('rw') | ||
|
|
||
| kernel_parameters.append(f'rootfstype={root.safe_fs_type.fs_type_mount}') | ||
| kernel_parameters.append(f'rootfstype={root.safe_fs_type}') |
There was a problem hiding this comment.
Wouldn't this format it as
rootfstype=FilesystemType.Ext4
The fs_type_mount function was also handling Fat32 type respectively with vfat
There was a problem hiding this comment.
Wouldn't this format it as
rootfstype=FilesystemType.Ext4
Yes, that is a mistake. I'm glad you caught that.
The
fs_type_mountfunction was also handlingFat32type respectively withvfat
The fs_type_mount function was only really being used for the rootfstype kernel parameter. FAT32 should not be used as a root file system so removing this should be fine.
Closes #4276