Handle whole-disk LUKS root params - #4205
Merged
Merged
Conversation
Torxed
approved these changes
Feb 3, 2026
codefiles
reviewed
Feb 3, 2026
Comment on lines
+57
to
+59
| if os.environ.get('ARCHINSTALL_SKIP_DEVICE_PROBE') == '1': | ||
| debug('Skipping device probe due to ARCHINSTALL_SKIP_DEVICE_PROBE=1') | ||
| return |
Contributor
|
I do not know why this was merged. It seems vibe coded. Was this actually reviewed before merging? |
correctmost
reviewed
Feb 3, 2026
| kernel_params = ' '.join(self._get_kernel_params(root)) | ||
| config_contents = 'timeout: 5\n' | ||
| config_contents = f'# Created by archinstall on {self.init_time}\\n' | ||
| config_contents += 'timeout: 5\\n' |
Contributor
There was a problem hiding this comment.
This escaping change looks incorrect (and also seems unrelated):
import time
init_time = time.strftime('%Y-%m-%d_%H-%M-%S')
config_contents = f'# Created by archinstall on {init_time}\\n'
config_contents += 'timeout: 5\\n'
print(config_contents)The code now prints everything on one line:
# Created by archinstall on 2026-02-03_06-52-35\ntimeout: 5\n
svartkanin
added a commit
that referenced
this pull request
Feb 3, 2026
This reverts commit 0dddc73.
Member
|
Well revert it. I reviewed it, but due to not doing it on my main computer I missed some of the syntax issues. I noted the environ use, and thought it might be a nice way of adding skips. I know it's different from how we do it today. But thought perhaps people prefer this ^^ |
correctmost
added a commit
to correctmost/archinstall
that referenced
this pull request
Feb 14, 2026
This reverts commit 0dddc73.
svartkanin
pushed a commit
that referenced
this pull request
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
Tests and Checks