Refactor wifi_handler to use dependency injection - #4161
Merged
Conversation
codefiles
force-pushed
the
wifi-handler-di
branch
from
January 22, 2026 14:50
e6ea548 to
46c1e11
Compare
codefiles
force-pushed
the
wifi-handler-di
branch
from
January 22, 2026 14:55
46c1e11 to
49e963b
Compare
svartkanin
reviewed
Jan 23, 2026
| else: | ||
| wifi_handler = None | ||
|
|
||
| if not _check_online(wifi_handler): |
Collaborator
There was a problem hiding this comment.
Is there a benefit in making this an optional parameter instead of creating the instance inside _check_online and avoiding the overhead?
Contributor
Author
There was a problem hiding this comment.
Yes, testability.
svartkanin
enabled auto-merge (squash)
January 23, 2026 03:39
svartkanin
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4149