Skip to content

Use Self in default_profiles #4125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
Jan 14, 2026
Merged

Use Self in default_profiles #4125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions archinstall/default_profiles/desktop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import TYPE_CHECKING, override
from typing import TYPE_CHECKING, Self, override

from archinstall.default_profiles.profile import GreeterType, Profile, ProfileType, SelectResult
from archinstall.lib.output import info
Expand All @@ -13,7 +13,7 @@


class DesktopProfile(Profile):
def __init__(self, current_selection: list[Profile] = []) -> None:
def __init__(self, current_selection: list[Self] = []) -> None:
super().__init__(
'Desktop',
ProfileType.Desktop,
Expand Down Expand Up @@ -68,7 +68,7 @@ def do_on_select(self) -> SelectResult:
group = MenuItemGroup(items, sort_items=True, sort_case_sensitive=False)
group.set_selected_by_value(self.current_selection)

result = SelectMenu[Profile](
result = SelectMenu[Self](
group,
multi=True,
allow_reset=True,
Expand Down
4 changes: 2 additions & 2 deletions archinstall/default_profiles/profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from __future__ import annotations

from enum import Enum, auto
from typing import TYPE_CHECKING
from typing import TYPE_CHECKING, Self

from archinstall.lib.translationhandler import tr

Expand Down Expand Up @@ -46,7 +46,7 @@ def __init__(
self,
name: str,
profile_type: ProfileType,
current_selection: list[Profile] = [],
current_selection: list[Self] = [],
packages: list[str] = [],
services: list[str] = [],
support_gfx_driver: bool = False,
Expand Down
6 changes: 3 additions & 3 deletions archinstall/default_profiles/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import TYPE_CHECKING, override
from typing import TYPE_CHECKING, Self, override

from archinstall.default_profiles.profile import Profile, ProfileType, SelectResult
from archinstall.lib.output import info
Expand All @@ -13,7 +13,7 @@


class ServerProfile(Profile):
def __init__(self, current_value: list[Profile] = []):
def __init__(self, current_value: list[Self] = []):
super().__init__(
'Server',
ProfileType.Server,
Expand All @@ -34,7 +34,7 @@ def do_on_select(self) -> SelectResult:
group = MenuItemGroup(items, sort_items=True)
group.set_selected_by_value(self.current_selection)

result = SelectMenu[Profile](
result = SelectMenu[Self](
group,
allow_reset=True,
allow_skip=True,
Expand Down