Modify archinstall language display to be handled like other sections. - #4048
Merged
Conversation
This fixes a bug where language names that were too long would break curses menu.
Contributor
Author
|
@svartkanin any thoughts on this one, I know these are fixed in textual but still in the meantime not a bad idea to make some UI enhancements |
Collaborator
|
I absolutely hate Githubs mobile app it's abysmal as it doesn't seem to be able to even add comments anymore. So I'll put it here: This utf character isn't supported in the ISO On another note, you need to be a bit patient with getting reviews, there's no ETA when they will happen as it's an open source project. We'll get to it when we get to it :) this may be a day, a week or even longer. |
Contributor
Author
|
No worries sorry about that I'm quite hyped at finally sending in all my stuff :D Also I agree lmao (about github mobile) |
svartkanin
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the value of
lang.display_namewas breaking the menu when too long. So just changed it to be handled like other sections.