User search now uses priority sorting to better display results for menu items. - #3966
Closed
okayGravity wants to merge 6 commits into
Closed
User search now uses priority sorting to better display results for menu items.#3966okayGravity wants to merge 6 commits into
okayGravity wants to merge 6 commits into
Conversation
…ion value and unit. - Allows for white space in between groups, aligning better with displayed example. - Removed unneeded | symbol, which was checking as literal rather than working as "or %"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
Previously, using search ('/') would capture user input to use in a filter containing a lambda function that filtered by the .contains() function. This returned the menu list but did not appropriately organize results to better display likely results.
example of previous results using filter "git"
This change adds the _items_score() function as a helper. This function scores, and gives priority to items that start with the user given filter.
example of new results using filter "git"
Tests and Checks