Default partuuid parameter of _get_kernel_params_partition() to false - #3947
Closed
Mintsuki wants to merge 1 commit into
Closed
Default partuuid parameter of _get_kernel_params_partition() to false#3947Mintsuki wants to merge 1 commit into
partuuid parameter of _get_kernel_params_partition() to false#3947Mintsuki wants to merge 1 commit into
Conversation
Mintsuki
force-pushed
the
no_partuuid
branch
from
November 25, 2025 14:26
7c6ef2b to
f13e9cc
Compare
partuuid parameter of _get_kernel_params_partition() to truepartuuid parameter of _get_kernel_params_partition() to false
Collaborator
|
Couold you provide a description of why this is needed? |
Contributor
Author
I have updated the original description. |
…alse There isn't a reason I could think of for preferring PARTUUIDs to UUIDs, since as far as I know that should work fine with all supported filesystems (and GRUB already forces this to false). This is especially important when using MBR instead of GPT, as that doesn't have proper UUIDs, and it will instead use the kernel's own conversion that is based on the MBR ID and more prone to collisions.
Mintsuki
force-pushed
the
no_partuuid
branch
from
November 26, 2025 01:16
f13e9cc to
2a694e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There isn't a reason I could think of for preferring PARTUUIDs to UUIDs, since as far as I know that should work fine with all supported filesystems (and GRUB already forces this to false). This is especially important when using MBR instead of GPT, as that doesn't have proper UUIDs, and it will instead use the kernel's own conversion that is based on the MBR ID and more prone to collisions.