Skip to content

Use dummy variables instead of unused-awaitable suppressions #3943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
Nov 22, 2025
Merged

Use dummy variables instead of unused-awaitable suppressions #3943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions archinstall/tui/ui/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ def __init__(self, allow_skip: bool = False, allow_reset: bool = False):

def action_cancel_operation(self) -> None:
if self._allow_skip:
self.dismiss(Result(ResultType.Skip, None)) # type: ignore[unused-awaitable]
_ = self.dismiss(Result(ResultType.Skip, None))

def action_reset_operation(self) -> None:
if self._allow_reset:
self.dismiss(Result(ResultType.Reset, None)) # type: ignore[unused-awaitable]
_ = self.dismiss(Result(ResultType.Reset, None))

def _compose_header(self) -> ComposeResult:
"""Compose the app header if global header text is available."""
Expand Down Expand Up @@ -93,7 +93,7 @@ def on_mount(self) -> None:
self.set_timer(self._timer, self.action_pop_screen)

def action_pop_screen(self) -> None:
self.dismiss() # type: ignore[unused-awaitable]
_ = self.dismiss()


class ConfirmationScreen(BaseScreen[ValueT]):
Expand Down Expand Up @@ -208,7 +208,7 @@ def on_key(self, event: Key) -> None:
item = self._group.focus_item
if not item:
return None
self.dismiss(Result(ResultType.Selection, item.value)) # type: ignore[unused-awaitable]
_ = self.dismiss(Result(ResultType.Selection, item.value))


class NotifyScreen(ConfirmationScreen[ValueT]):
Expand Down Expand Up @@ -313,7 +313,7 @@ def on_key(self, event: Key) -> None:
if event.key == 'enter':
input_field = self.query_one('#main_input', Input)
value = input_field.value
self.dismiss(Result(ResultType.Selection, value)) # type: ignore[unused-awaitable]
_ = self.dismiss(Result(ResultType.Selection, value))


class TableSelectionScreen(BaseScreen[ValueT]):
Expand Down Expand Up @@ -434,7 +434,7 @@ def _display_header(self, is_loading: bool) -> None:

def _put_data_to_table(self, table: DataTable[ValueT], data: list[ValueT]) -> None:
if not data:
self.dismiss(Result(ResultType.Selection, None)) # type: ignore[unused-awaitable]
_ = self.dismiss(Result(ResultType.Selection, None))
return

cols = list(data[0].table_data().keys()) # type: ignore[attr-defined]
Expand All @@ -454,7 +454,7 @@ def _put_data_to_table(self, table: DataTable[ValueT], data: list[ValueT]) -> No

def on_data_table_row_selected(self, event: DataTable.RowSelected) -> None:
data: ValueT = event.row_key.value # type: ignore[assignment]
self.dismiss(Result(ResultType.Selection, data)) # type: ignore[unused-awaitable]
_ = self.dismiss(Result(ResultType.Selection, data))


class TApp(App[Any]):
Expand Down