Add dialog to install EFI bootloader to removable location - #3932
Merged
Conversation
Mintsuki
marked this pull request as draft
November 16, 2025 05:05
Mintsuki
force-pushed
the
limine-removable
branch
6 times, most recently
from
November 16, 2025 06:23
f5af338 to
cba59d8
Compare
Mintsuki
marked this pull request as ready for review
November 16, 2025 06:40
Collaborator
|
i think this should go under a new Bootloader sub-menu instead of a global namespace setting. |
svartkanin
reviewed
Nov 16, 2025
Mintsuki
marked this pull request as draft
November 16, 2025 18:26
Mintsuki
force-pushed
the
limine-removable
branch
4 times, most recently
from
November 16, 2025 19:50
8632ca0 to
101b56c
Compare
Mintsuki
marked this pull request as ready for review
November 16, 2025 20:52
Contributor
Author
|
The PR should be ready for review now. Please, beware that I have used LLMs for most of these changes due to my unfamiliarity with the codebase, and while I have reviewed and tested the code, I would strongly recommend someone familiar with the codebase to thoroughly review the changes. |
Mintsuki
force-pushed
the
limine-removable
branch
3 times, most recently
from
November 16, 2025 22:16
9f13022 to
2ac2d75
Compare
This is just for GRUB and Limine for now.
svartkanin
reviewed
Nov 17, 2025
Contributor
Author
|
Anything else I should change before approval? |
svartkanin
reviewed
Nov 20, 2025
svartkanin
reviewed
Nov 20, 2025
svartkanin
reviewed
Nov 20, 2025
svartkanin
reviewed
Nov 20, 2025
Collaborator
|
Sorry I was too busy, I tested the code and it seems to work, great job in making the config backwards compatible. |
Mintsuki
force-pushed
the
limine-removable
branch
13 times, most recently
from
November 20, 2025 13:40
0c5c3ee to
3c349a0
Compare
Mintsuki
force-pushed
the
limine-removable
branch
from
November 20, 2025 21:05
3c349a0 to
2acdaef
Compare
svartkanin
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just for GRUB and Limine for now.