Added a check to prevent [multilib-testing] from being enabled on non-multilib systems - #3916
Closed
meatsnails wants to merge 0 commit into
Closed
Added a check to prevent [multilib-testing] from being enabled on non-multilib systems#3916meatsnails wants to merge 0 commit into
meatsnails wants to merge 0 commit into
Conversation
correctmost
reviewed
Nov 10, 2025
| if repo == Repository.Testing: | ||
| repos_to_enable.extend(['core-testing', 'extra-testing', 'multilib-testing']) | ||
| repos_to_enable.extend(['core-testing', 'extra-testing']) | ||
| elif repo == Repository.Multilib: |
Contributor
There was a problem hiding this comment.
It looks like this change would prevent Repository.Multilib.value from being appended to repos_to_enable.
Author
There was a problem hiding this comment.
my oversight I think i fixed it and let me test it some more to be sure
meatsnails
marked this pull request as draft
November 10, 2025 20:49
Author
|
closing this because I made the git log a mess (end my suffering) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix to the issue I described in #3915
I added a check to the archinstall/lib/pacman/config.py under the repos_to_enable logic that ensures multilib-testing will only be enabled when multilib and testing are both set
I tested by installing in a VM from the latest iso (archlinux-2025.11.01-x86_64.iso) both with and without multilib + testing and both times (I watched during the install process and checked the installed system's pacman.conf file to ensure the repos we properly set)