--needed prevent re-installs & fix #issues/3599 - #3913
Conversation
|
Could you please fix the linting and formatting, you may wanna setup the pre-commit hooks |
|
Hi @svartkanin thanks for tip. And also, for reproducing the bug in my issue report couple months ago. Seems to pass now, sry new to larger code-bases. |
|
h8d13
changed the title
|
Final note: Tested using the patch and official ISO: with layout And LUKS2 unlock with grub worked out of the box without requiring ckbcomp files <3 My understanding from: # https://gitlab.archlinux.org/archlinux/mkinitcpio/mkinitcpio/-/commit/d0a98218d2444b939cf4932265cc70a6a89a8d22 Is that this call for hook keymap is not needed anymore. And the font is also set there: https://man.archlinux.org/man/vconsole.conf.5 Ln782:
|
|
Added a def for the vconsole.conf and also 
|
|
There are a lot of different changes in this PR and to keep an overview of what is being changed I'd suggest to split them into separate PRs |
| GfxPackage.VulkanSwrast, | ||
| ] | ||
|
|
||
| if self.is_nvidia() and (SysInfo.has_intel_graphics() or SysInfo.has_amd_graphics()): |
There was a problem hiding this comment.
shouldn't the second clause contain a not ?
There was a problem hiding this comment.
I was thinking it actually needs a is laptop check?
To safeguard multi gpu setups
We can check this using form factor or battery power. Also no there are many amd iGPU setups too
| """ | ||
| self._base_packages = base_packages or __packages__[:3] | ||
| self.kernels = kernels or ['linux'] | ||
| self.config: dict[str, Any] = {} |
There was a problem hiding this comment.
Yeah the commit hooks were screaming if I didn't add this fir some reason and I'm unfamiliar with how to link to config
| 'filesystems', | ||
| 'fsck', | ||
| ] | ||
| # https://gitlab.archlinux.org/archlinux/mkinitcpio/mkinitcpio/-/commit/d0a98218d2444b939cf4932265cc70a6a89a8d22 |
There was a problem hiding this comment.
Why do we need this comment?
There was a problem hiding this comment.
Thought it might be useful as hooks might need chnage and wasn't sure about this part :)
| fstab_path = self.target / 'etc' / 'fstab' | ||
| info(f'Updating {fstab_path}') | ||
|
|
||
| # see GENFSTAB(8) to limit to mountpoint fixes https://github.com/archlinux/archinstall/issues/3599 |
There was a problem hiding this comment.
I don't think we need this comment as the PR commit should guide the change to the linked issue
| # https://www.gnu.org/software/grub/manual/grub/grub.html#Input-terminal | ||
| locale_cfg = locale_config or LocaleConfiguration.default() | ||
| self.set_vconsole(locale_cfg) | ||
| # Also fixes https://github.com/archlinux/archinstall/issues/3160 |
There was a problem hiding this comment.
Please raise this fix as a separate PR so it can be properly linked to the issue in GH
There was a problem hiding this comment.
Also there's no need to have these issues as comments
There was a problem hiding this comment.
Ah was just following how the current code documents issues
I'll split them and redice the comments
|
I've split it into 5 clean branches in repo Master (Pacgenfstab), Hardware, Snapshots, Vconsole & Readme Removed most of comments kept only ones in vconsole Hope this is what you needed 👍 |
h8d13
changed the title
2 participants
Fix host-to-target installs using
-fin genfstabFix overlapping meta package vs drivers installs using
--neededgrep install logs forre-installingFix Snapper-Grub integration similar to how
timeshiftis handledFix mkinitcpio v40
vconsole.confhookAdded support for hybrid laptops to conditionally add
nvidia-primeAdded VM fix as many apps need software render fallback
vulkan-swrastTested many times using full-disk best effort: on
MSI GP72 6QENvidia 950M + Intel iGPUThis would notably effect positively: Both amd/intel iGPU + NVIDIA dGPU setups:
Allowing for
prime-run <intensive-app>EDIT: Readme fix because I see many logs(mostly on reddit) using outdated version since it's not mentioned you need to update archinstall and then some people recpmmend -Syu archinstall on ISO which isn't great.
I have also added documentation at each step so that if you don't use the full PR it might still help =)