Skip to content

Upgrade Pylint to 4.0.0 #3867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
Oct 13, 2025
Merged

Upgrade Pylint to 4.0.0 #3867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pylint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
pacman --noconfirm -Syyu
pacman --noconfirm -Sy python-pip python-pyparted pkgconfig gcc
- run: pip install --break-system-packages --upgrade pip
- name: Install Pylint and Pylint plug-ins
- name: Install Pylint
run: pip install --break-system-packages .[dev]
- run: python --version
- run: pylint --version
Expand Down
1 change: 0 additions & 1 deletion PKGBUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ makedepends=(
'python-wheel'
'python-sphinx_rtd_theme'
'python-pylint'
'python-pylint-pydantic'

@correctmost correctmost Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Torxed - The PKGBUILD file in https://gitlab.archlinux.org/archlinux/packaging/packages/archinstall might need to be updated too

'ruff'
)
optdepends=(
Expand Down
2 changes: 2 additions & 0 deletions archinstall/lib/models/users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ def strength(cls, password: str) -> 'PasswordStrength':
symbol = any(not character.isalnum() for character in password)
return cls._check_password_strength(digit, upper, lower, symbol, len(password))

# TODO: Remove the disable line when https://github.com/pylint-dev/pylint/issues/10647 is fixed
# pylint: disable=bare-name-capture-pattern
@classmethod
def _check_password_strength(
cls,
Expand Down
4 changes: 1 addition & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ dev = [
"flake8==7.3.0",
"pre-commit==4.3.0",
"ruff==0.14.0",
"pylint==3.3.9",
"pylint-pydantic==0.3.5",
"pylint==4.0.0",
"pytest==8.4.2",
]
doc = ["sphinx"]
Expand Down Expand Up @@ -137,7 +136,6 @@ ignore-paths = [
"^build/",
"^docs/",
]
load-plugins = ["pylint_pydantic"]
persistent = false
py-version = "3.12"
recursive = true
Expand Down