Skip to content
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

[ruby] Upgrade rubocop to version 1.48.0#339

Closed
depfu[bot] wants to merge 1 commit into
mainfrom
depfu/update/rubocop-1.48.0
Closed

[ruby] Upgrade rubocop to version 1.48.0#339
depfu[bot] wants to merge 1 commit into
mainfrom
depfu/update/rubocop-1.48.0

Conversation

@depfu

@depfu depfu Bot commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.40.0 → ~> 1.48.0) · Repo · Changelog

Release Notes

1.48.0

New features

Bug fixes

  • #11654: Fix a false positive for Lint/MissingSuper when no super call and when defining some method. (@koic)
  • #11661: Fix an error for Style/Documentation when namespace is a variable. (@koic)
  • #11647: Fix an error for Style/IfWithBooleanLiteralBranches when using () as a condition. (@koic)
  • #11646: Fix an error for Style/NegatedIfElseCondition when using () as a condition. (@koic)
  • #11659: Fix an incorrect autocorrect for Lint/OrAssignmentToConstant when using or-assignment to a constant in method definition. (@koic)
  • #11663: Fix an incorrect autocorrect for Style/BlockDelimiters when multi-line blocks to { and } with arithmetic operation method chain. (@koic)
  • #11638: Fix a false positive for Lint/UselessAccessModifier when using same access modifier inside and outside the included block. (@ydah)
  • #11164: Suppress server mode message with -f json. (@jasondoc3)
  • #11643: Fix incorrect shorthand autocorrections in calls inside parentheses. (@gsamokovarov)
  • #11650: Style/AccessorGrouping: Fix detection of Sorbet sig {} blocks. (@issyl0)
  • #11657: Use cop name to check if cop inside registry is enabled. Previously, it was able to cause large memory usage during linting. (@fatkodima)

Changes

  • #11482: Avoid comment deletion by Style/IfUnlessModifier when the modifier form expression has long comment. (@nobuyo)
  • #11649: Support MinBranchesCount config for Style/CaseLikeIf cop. (@fatkodima)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 23 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu Bot added the depfu label Mar 7, 2023
@depfu

depfu Bot commented Mar 14, 2023

Copy link
Copy Markdown
Contributor Author

Closed in favor of #342.

@depfu depfu Bot closed this Mar 14, 2023
@depfu depfu Bot deleted the depfu/update/rubocop-1.48.0 branch March 14, 2023 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants