Skip to content
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

[ruby] Upgrade rubocop to version 1.41.0#319

Closed
depfu[bot] wants to merge 1 commit into
mainfrom
depfu/update/rubocop-1.41.0
Closed

[ruby] Upgrade rubocop to version 1.41.0#319
depfu[bot] wants to merge 1 commit into
mainfrom
depfu/update/rubocop-1.41.0

Conversation

@depfu

@depfu depfu Bot commented Dec 21, 2022

Copy link
Copy Markdown
Contributor

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.40.0 → ~> 1.41.0) · Repo · Changelog

Release Notes

1.41.0

New features

  • #11305: Add new Style/RedundantDoubleSplatHashBraces cop. (@koic)
  • #10812: New AllowMultilineFinalElement option for all LineBreaks cops. (@Korri)
  • #11277: Add new Style/ConcatArrayLiterals cop. (@koic)

Bug fixes

  • #11255: Fix an error for Style/RequireOrder when require with no arguments is put between require. (@ydah)
  • #11273: Fix a false positive for Lint/DuplicateMethods when there are same alias_method name outside rescue or ensure scopes. (@koic)
  • #11267: Fix an error for Style/RequireOrder when modifier conditional is used between require. (@ydah)
  • #11254: Fix an error for Style/RequireOrder when require is a method argument. (@koic)
  • #11266: Fix a false positive for Style/RedundantConstantBase when enabling Lint/ConstantResolution. (@koic)
  • #11296: Fix an error for Lint/NonAtomicFileOperation when use file existence checks line break unless by postfix before creating file. (@koic)
  • #11284: Fix an incorrect autocorrect for Style/WordArray when assigning %w() array. (@koic)
  • #11299: Fix base_dir in TargetFinder#find_files(). (@dukaev)
  • #11250: Fix an error for Style/GuardClause when a method call whose last argument is not a string is in the condition body. (@ydah)
  • #11298: Fix Lint/SafeNavigationChain to correctly handle [] operator followed by save navigation and method chain. (@fatkodima)
  • #11256: Fix an incorrect autocorrect for Style/HashSyntax when without parentheses call expr follows after multiple keyword arguments method call. (@koic)
  • #11289: Correctly detect Rails version when using only parts of the framework, instead of the "rails" gem. (@bdewater)
  • #11262: Fix an error for Style/IfUnlessModifier when the body is a method call with hash splat. (@fatkodima)
  • #11281: Fix NoMethodError for Style/Documentation when a class nested under non-constant values. (@arika)

Changes

  • #11306: Make Style/IfWithSemicolon aware of one line without else body. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 55 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu Bot added the depfu label Dec 21, 2022
@codecov

codecov Bot commented Dec 21, 2022

Copy link
Copy Markdown

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (2766177) compared to base (26de50f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #319   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           33        33           
=========================================
  Hits            33        33           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@depfu

depfu Bot commented Dec 23, 2022

Copy link
Copy Markdown
Contributor Author

Closed in favor of #321.

@depfu depfu Bot closed this Dec 23, 2022
@depfu depfu Bot deleted the depfu/update/rubocop-1.41.0 branch December 23, 2022 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants