Skip to content

fix: replace unsupported forceUTC option in tests#266

Open
vdistortion wants to merge 1 commit into
archiverjs:masterfrom
vdistortion:fix-forceutc-tests
Open

fix: replace unsupported forceUTC option in tests#266
vdistortion wants to merge 1 commit into
archiverjs:masterfrom
vdistortion:fix-forceutc-tests

Conversation

@vdistortion
Copy link
Copy Markdown

The current tests use the undocumented forceUTC option:

new Packer({ forceUTC: true })

However, the implementation only reads options.forceLocalTime:

entry.setTime(data.date, this.options.forceLocalTime)

and there is no runtime reference to forceUTC.

This PR replaces forceUTC: true with the equivalent supported option:

forceLocalTime: false

to align the tests with the actual public API.

@vdistortion
Copy link
Copy Markdown
Author

This may also be related to a mismatch in archiver:
archiverjs/node-archiver#843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant