Skip to content

chore: upgrade glob to remove deprecated inflight dependency#205

Open
CodeByAmrit wants to merge 1 commit into
archiverjs:masterfrom
CodeByAmrit:chore/upgrade-glob-remove-inflight
Open

chore: upgrade glob to remove deprecated inflight dependency#205
CodeByAmrit wants to merge 1 commit into
archiverjs:masterfrom
CodeByAmrit:chore/upgrade-glob-remove-inflight

Conversation

@CodeByAmrit
Copy link
Copy Markdown

What changed

  • Upgraded glob to a maintained version
  • Removed deprecated inflight dependency

Why

  • inflight is deprecated and known to leak memory
  • glob@7 is no longer supported

Notes

  • No runtime code changes
  • Public API unchanged
  • All tests pass

@CodeByAmrit
Copy link
Copy Markdown
Author

This PR removes the deprecated glob@7 → inflight dependency by upgrading to a maintained version of glob.
No runtime code changes were required and all tests pass.

@senoff
Copy link
Copy Markdown

senoff commented May 4, 2026

Validating this against a downstream consumer to help unstick review:

Built a tarball from this branch (c3193df) and installed it into a recent @protobi/exceljs working tree via npm overrides, then ran exceljs's full headless test suite. The dependency tree confirms archiver → archiver-utils → glob@13.0.6 (replacing the previously-deprecated glob@10.5.0).

test:unit         884 passing,  1 pending
test:integration  200 passing
test:end-to-end     1 passing
                 ─────────────
                 1,085 passing, 0 failing

(Skipped test:jasmine — needs a browser harness, not relevant to this dep change.)

So the glob 10 → 13 bump survives a real downstream's full test suite cleanly. Hopefully useful evidence for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants