feat: sync data gateway object contract#13
Merged
Conversation
zz-jason
reviewed
May 21, 2026
Contributor
zz-jason
left a comment
zz-jason
left a comment
There was a problem hiding this comment.
Reviewed the Swift SDK object-contract sync. Main risks are around production behavior coverage: listObjects currently bypasses the existing control-plane retry policy, and the new object-service path is only covered by stubs rather than a real gRPC/integration contract test. The remaining comments are non-blocking cleanup/API-hardening suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --checkswift testScripts/gen_swift_proto.shidempotency check against generated sources