fix(agent): align effort schema with provider-specific capabilities#234
fix(agent): align effort schema with provider-specific capabilities#234lucas77778 wants to merge 5 commits into
Conversation
Co-authored-by: Chenyu Lu <chenyu@arcbox.dev>
CODE-330 fix(agent): align effort schema with provider-specific capabilities
ProblemThe normalized effort contract is a single global enum and the UI keeps provider effort choices in static tables. That contract no longer matches the pinned Codex 0.144.1 provider:
A configured Codex Root causeEffort vocabulary and availability are modeled globally, although they are provider- and model-specific. The adapter already reads Fix
Acceptance
EvidenceVerified directly against the repository-pinned |
Greptile SummaryThis PR aligns reasoning-effort handling with each provider and model. The main changes are:
Confidence Score: 5/5This looks safe to merge. Optional or empty Codex catalogs no longer block session startup. Pending model selections survive stale updates and process recovery. No blocking issues were found in the changed code.
What T-Rex did
Important Files Changed
Reviews (5): Last reviewed commit: "fix(agent): resolve effort review blocke..." | Re-trigger Greptile |
Co-authored-by: Chenyu Lu <chenyu@arcbox.dev>
Co-authored-by: Chenyu Lu <chenyu@arcbox.dev>
Co-authored-by: Chenyu Lu <chenyu@arcbox.dev>
Zerlight
left a comment
There was a problem hiding this comment.
Requesting changes for two correctness issues:
- The inline comment covers the live pending-selection lifetime.
- The static fallback capability metadata is not used by draft submission.
new-session-surface.tsx:169-174resolvesmodelOptiononly fromdynamicModels, while this PR adds model-specific fallback capabilities inagent-models.ts:90-108. Ifmodel/listis unavailable, a remembered Solultraselection can survive after selecting Luna and is submitted even though the fallback table excludes it, causing the first turn to fail. Resolve the selected model from the dynamic catalog orAGENT_MODEL_OPTIONS[provider]consistently before calculatingconstrainedEffort.
The pinned 0.144.1 protocol shape and CI both check out; these are the remaining blockers.
|
Addressed the second review blocker in cd7cb81. |
Summary
ultralevel and advertise per-model effort capabilities/defaultsmodel/listmetadata for pre-session and live catalogs, validating startup and live model/effort selections against the selected modelultraseparate from Claude'sultracode, update effort filtering/fallbacks, and preserve pending picks across stale settings notificationsVerification
pnpm test(210 files, 1,634 tests)pnpm check:cigit diff --checksupportedReasoningEffortsprotocol shape against@openai/codex 0.144.1Linear: CODE-330