Skip to content

Adds new ice models for upward and downward systematics.#226

Merged
Machtay merged 3 commits into
masterfrom
add_systematic_error_ice_models
Jun 5, 2026
Merged

Adds new ice models for upward and downward systematics.#226
Machtay merged 3 commits into
masterfrom
add_systematic_error_ice_models

Conversation

@Machtay

@Machtay Machtay commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

The new ice models are 41 and 42. They add the systematics from here to the ice model 40 parameters: https://aradocs.wipac.wisc.edu/0035/003525/002/5SA_Ice_Model_Uncertainties.pdf

@Machtay Machtay requested review from AlanSalcedo and marcomuzio June 5, 2026 17:22

@marcomuzio marcomuzio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Machtay this looks good. Can you just add these to the high-level docs in Settings.h?

int RAY_TRACE_ICE_MODEL_PARAMS; // which parameter set is used for the exponential ice model (defined in RayTrace_IceModel.cc)

@clark2668

Copy link
Copy Markdown
Collaborator

Agreed about adding to docs, otherwise good.

@Machtay

Machtay commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Added to the docs

@marcomuzio marcomuzio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Machtay Machtay merged commit 4fcf1f3 into master Jun 5, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants