Skip to content

Update to Selenium 4.49.0 +semver:feature - #167

Merged
mialeska merged 1 commit into
masterfrom
enhancement/update-to-selenium-4.49.0
Sep 25, 2026
Merged

mialeska merged 1 commit into
masterfrom
enhancement/update-to-selenium-4.49.0

Conversation

@mialeska

Copy link
Copy Markdown
Contributor

Update dependency versions.
Update DevTools references to v153 (use 152 in custom version tests)

Update dependency versions.
Update DevTools references to v153 (use 152 in custom version tests)
@mialeska mialeska self-assigned this Sep 25, 2026
@mialeska mialeska added enhancement New feature or request dependencies Pull requests that update a dependency file java labels Sep 25, 2026
@github-project-automation github-project-automation Bot moved this to In progress in Aquality Selenium Sep 25, 2026
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: f8a3bce4-13b5-45d3-b615-8dedf8b90caf

📥 Commits

Reviewing files that changed from the base of the PR and between 04d424a and bdf3345.

📒 Files selected for processing (8)
  • pom.xml
  • src/main/java/aquality/selenium/browser/devtools/DevToolsHandling.java
  • src/main/java/aquality/selenium/browser/devtools/EmulationHandling.java
  • src/main/java/aquality/selenium/browser/devtools/JavaScriptHandling.java
  • src/main/java/aquality/selenium/browser/devtools/NetworkHandling.java
  • src/test/java/tests/usecases/devtools/DeviceEmulationTest.java
  • src/test/java/tests/usecases/devtools/NetworkSpeedEmulationTest.java
  • src/test/java/tests/usecases/devtools/OverrideUserAgentTest.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The aquality-selenium-core dependency changed from version 4.18.0 to 4.19.0. Production DevTools imports changed to protocol v153. Test imports changed to protocol v152 or v153.

Changes

DevTools dependency and protocol updates

Layer / File(s) Summary
Dependency and DevTools imports
pom.xml, src/main/java/aquality/selenium/browser/devtools/*, src/test/java/tests/usecases/devtools/*
The core dependency changed from 4.18.0 to 4.19.0. Production imports changed from DevTools v152 to v153. Test imports changed from v151 to v152 or from v152 to v153.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to bdf33

The dependency supplies the required DevTools versions. No identified issue prevents merging after normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to bdf33

The change affects 2 systems.

Changed systems: src, pom.xml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 7 changed files map to changed impact.
  • observed — pom.xml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in pom.xml: The aquality-selenium-core dependency version changed from 4.18.0 to 4.19.0.
  • observed — Modified behavior in src/main/java/aquality/selenium/browser/devtools/DevToolsHandling.java: The performance command and metric imports now reference Selenium protocol version v153 instead of v152.
  • observed — Modified behavior in src/main/java/aquality/selenium/browser/devtools/EmulationHandling.java: All seven DevTools type imports used by emulation handling now reference protocol version v153 instead of v152.
  • observed — Modified behavior in src/main/java/aquality/selenium/browser/devtools/JavaScriptHandling.java: Imports now use the v153 DevTools page and runtime APIs instead of v152.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Selenium dependency update to version 4.49.0. It also matches the DevTools reference changes in the pull request.
Description check ✅ Passed The description accurately summarizes the dependency update and the DevTools version changes, including the custom-version test exception.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 7…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the version trail,
New protocol names replace the stale.
The imports hop from old to new,
The tests make matching changes too.
One neat update, then off I go,
With carrots packed and ears aglow.

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@mialeska
mialeska merged commit 8465781 into master Sep 25, 2026
6 checks passed
@mialeska
mialeska deleted the enhancement/update-to-selenium-4.49.0 branch September 25, 2026 15:30
@coderabbitai coderabbitai Bot mentioned this pull request Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request java

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant