Repository navigation
Reelwright 2.2: scene-kit — stages, cast, lights, motion, shots - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
kit/lib/scene-kit.jsand moves the film onto it.Before this, the character system (rigged avatar, bone poses, mouth morphs off
envelope.json, material conversion, contact shadows) lived only insidetemplates/scene.js— 1,100 lines hard-wired to one shop set. Any film with asecond location had to hand-build a renderer, lights, cast and HUD from scratch.
scene-kit.jsis that work extracted and parameterised:shotPickercuts between camera setups inside a stage (wide, close-up, low angle).makeHuman, eight poses,poseHuman,speak,mouthAt,walkCycle,headLook.motes,snowfall,handheldcamera drift,windowOpeningso the same mountain is visible outside every interior.Also:
build.pyships the module,docs/scene-kit.mddocuments it and states thelimits plainly (no walk clips, no IK, no facial animation beyond the mouth, hard
cuts only, one rig recoloured per character), and the README/START-HERE no longer
imply that a new film needs no scene code.
Includes the worked film
films/everest/— five locations, eight shots, movingcast, 36.6 s, QA pass.