Smart Watch 4 JS UI design#1
Open
mahesh-11102 wants to merge 7 commits intoapplibgroup:mainfrom
Open
Conversation
archanaatr
reviewed
Mar 2, 2022
| @@ -0,0 +1,23 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
archanaatr
reviewed
Mar 2, 2022
| @@ -0,0 +1,61 @@ | |||
| { | |||
| "app": { | |||
| "bundleName": "com.example.watch4.hmservice", | |||
There was a problem hiding this comment.
bundleName - can be more appropriate, for example - com.hmos.app.watch4 etc
archanaatr
reviewed
Mar 2, 2022
| @@ -0,0 +1,10 @@ | |||
| package com.example.watch4; | |||
There was a problem hiding this comment.
Please add copyright details to all the new files
archanaatr
reviewed
Mar 2, 2022
archanaatr
reviewed
Mar 2, 2022
| export default { | ||
| data: { | ||
| weather: "sun & windy", | ||
| // cloudy, windy, partly sunny, rainy, sleeting, sun & rain, sun & windy, sunny, thunderstorm & rain, thunderstorm |
There was a problem hiding this comment.
UI functionality is fine, please include the api exposing functionality where in data layer need to be segregated as per the requirement.
archanaatr
reviewed
Apr 19, 2022
| *.iml | ||
| .gradle | ||
| /local.properties | ||
| /.idea/caches |
archanaatr
reviewed
Apr 19, 2022
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "strings": { | |||
| "hello": "Hello", | |||
archanaatr
reviewed
Apr 19, 2022
| fecthWeather : function(){ | ||
| let data; | ||
| fetch.fetch({ | ||
| url:'https://api.openweathermap.org/data/2.5/weather?lat=16.5062&lon=80.6480&appid=9ca3abfc02f621a4fe7696f670f04a57', |
There was a problem hiding this comment.
Try to get current location and use that latitude and longitude values to fetch the weather
archanaatr
reviewed
Apr 19, 2022
archanaatr
left a comment
archanaatr
left a comment
There was a problem hiding this comment.
Please check the comments added today
archanaatr
reviewed
May 5, 2022
| @@ -0,0 +1,16 @@ | |||
| package com.hmos.app.watch4; | |||
There was a problem hiding this comment.
pls add copyright details in all new js / ets files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshot of my work
If any changes are required Please Guide me.