Strip newlines when parsing events - #206
Merged
czechboy0 merged 3 commits intoJul 30, 2026
Merged
Conversation
czechboy0
reviewed
Jul 30, 2026
czechboy0
left a comment
czechboy0
left a comment
Contributor
There was a problem hiding this comment.
Just a nit, lgtm otherwise - thanks @kukushechkin 🙏
…wift Co-authored-by: Honza Dvorsky <honza@apple.com>
czechboy0
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
idandeventfields aren't normalized the same waydataalready is, so they could end up split across multiple lines.Modifications
Strip newlines from
idandevent.Result
idandeventeach is serialized into a single line.Test Plan
Unit test.