Fix parsing of empty long option values - #959
Open
actuallyhrishikesh wants to merge 1 commit into
Open
Conversation
actuallyhrishikesh
requested review from
natecook1000 and
rauhul
as code owners
August 26, 2026 09:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #958.
This change treats the presence of
=in a long option as an explicit attached value, including empty values.For example:
--output=
is now parsed as an option with an empty string value rather than being treated as a bare flag.
Tests:
--output=.Compatibility note:
--flag=is now treated as a flag with an explicit empty attached value, consistent with the existing single-dash-f=behavior and the issue's explicit=rule.