Skip to content

Fix: Use visibility.base consistently in generateHelpNames for .longWithSingleDash #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AkshatRaj00 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Use visibility.base consistently in generateHelpNames for .longWithSingleDash #902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/ArgumentParser/Usage/HelpGenerator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ extension NameSpecification {
case .long(let helpName):
return .long("\(helpName)-\(visibility.base)")
case .longWithSingleDash(let helpName):
return .longWithSingleDash("\(helpName)-\(visibility)")
return .longWithSingleDash("\(helpName)-\(visibility.base)") // Fix: use .base for consistency with .long case

@natecook1000 natecook1000 Aug 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the comment here – it makes sense in the context of this PR, but not when reading the code by itself.

Suggested change
return .longWithSingleDash("\(helpName)-\(visibility.base)") // Fix: use .base for consistency with .long case
return .longWithSingleDash("\(helpName)-\(visibility.base)")

case .short:
// Cannot create a non-default help flag from a short name.
return nil
Expand Down
Loading