Enforce that abstract methods are implemented#1785
Open
HT154 wants to merge 1 commit into
Open
Conversation
HT154
commented
Jul 20, 2026
Comment on lines
+2
to
+4
| Class `abstractMethodNotImplemented2#MyClass` should either be declared `abstract`, or implement the following methods: | ||
| foo() | ||
| bar() |
Contributor
Author
There was a problem hiding this comment.
This is a style change compared to #1690 to match how candidates in "Cannot find method" errors are displayed.
HT154
force-pushed
the
abstract-method-implementation-check
branch
3 times, most recently
from
July 20, 2026 17:58
20cf953 to
fd9fc8a
Compare
This adds a check that abstract members must be implemented. If any members lack an implementation, an error is thrown describing the missing members. Also: we have a bug in `pkl:base`; class `Set` does not implement all members of class `Collection`.
HT154
force-pushed
the
abstract-method-implementation-check
branch
from
July 20, 2026 18:01
fd9fc8a to
4fb7ec8
Compare
HT154
changed the title
HT154
marked this pull request as ready for review
July 21, 2026 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a check that abstract methods must be implemented. If any members lack an implementation, an error is thrown describing the missing methods.
Also: we have a bug in
pkl:base; classSetdoes not implement all members of classCollection.Supersedes #1690 if we merge #1781