Initialize endpoints in DD team collection tests#13405
Initialize endpoints in DD team collection tests#13405tclinkenbeard-oai wants to merge 1 commit into
Conversation
tclinkenbeard-oai
left a comment
There was a problem hiding this comment.
Generated by Codex.
What is it trying to do?
Make the fdbserver_datadistributor_test fixtures safe outside simulation by giving each synthetic StorageServerInterface a valid, unregistered getValue endpoint. Both fixture builders now initialize it before code reads or logs interface.address().
Is it correct?
Yes, based on code inspection. StorageServerInterface::address() is derived from getValue, and the helper supplies a valid one-address Endpoint with a unique port and token per fixture server. The helper is called in both fixture loops before TCServerInfo construction and before the machine-fixture address log.
This is test-only setup. It changes no serialized layout, persisted value, production hot path, actor/coroutine lifetime, counter, or async request behavior. I inspected the endpoint/address implementation, fixture coverage, DD address consumers, and unit-test registrations. I did not build or run tests.
Public clang-format passes. Test Boost CONFIG Mode on Windows and the FoundationDB CI builders are still pending, with no visible failures.
Are there bugs?
I did not find any correctness bugs.
Are there omissions?
None that I think block this. The existing DD unit tests are the relevant regression surface because they all use one of the two updated fixture builders. The pending CI should finish before merge.
Are there better ways of doing things?
The shared helper is the right minimal approach. Initializing every request stream would be broader than needed because these tests only require a valid address source.
Should this CL be LGTMd?
Yes, LGTM based on code inspection. The highest remaining risk is compilation or execution coverage from the pending CI checks.
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Result of foundationdb-pr-clang on Linux RHEL 9
|
Result of foundationdb-pr on Linux RHEL 9
|
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Result of foundationdb-pr-macos on macOS 14.x
|
This PR fixes
fdbserver_datadistributortest failures outside of simulation, similar to #13397.