Skip to content

Initialize endpoints in DD team collection tests#13405

Open
tclinkenbeard-oai wants to merge 1 commit into
apple:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/datadistributor-add-all-teams-test
Open

Initialize endpoints in DD team collection tests#13405
tclinkenbeard-oai wants to merge 1 commit into
apple:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/datadistributor-add-all-teams-test

Conversation

@tclinkenbeard-oai

Copy link
Copy Markdown
Collaborator

This PR fixes fdbserver_datadistributor test failures outside of simulation, similar to #13397.

@tclinkenbeard-oai tclinkenbeard-oai left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated by Codex.

What is it trying to do?

Make the fdbserver_datadistributor_test fixtures safe outside simulation by giving each synthetic StorageServerInterface a valid, unregistered getValue endpoint. Both fixture builders now initialize it before code reads or logs interface.address().

Is it correct?

Yes, based on code inspection. StorageServerInterface::address() is derived from getValue, and the helper supplies a valid one-address Endpoint with a unique port and token per fixture server. The helper is called in both fixture loops before TCServerInfo construction and before the machine-fixture address log.

This is test-only setup. It changes no serialized layout, persisted value, production hot path, actor/coroutine lifetime, counter, or async request behavior. I inspected the endpoint/address implementation, fixture coverage, DD address consumers, and unit-test registrations. I did not build or run tests.

Public clang-format passes. Test Boost CONFIG Mode on Windows and the FoundationDB CI builders are still pending, with no visible failures.

Are there bugs?

I did not find any correctness bugs.

Are there omissions?

None that I think block this. The existing DD unit tests are the relevant regression surface because they all use one of the two updated fixture builders. The pending CI should finish before merge.

Are there better ways of doing things?

The shared helper is the right minimal approach. Initializing every request stream would be broader than needed because these tests only require a valid address source.

Should this CL be LGTMd?

Yes, LGTM based on code inspection. The highest remaining risk is compilation or execution coverage from the pending CI checks.

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: 0c7f483
  • Duration 0:22:51
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux RHEL 9

  • Commit ID: 0c7f483
  • Duration 0:45:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS 14.x

  • Commit ID: 0c7f483
  • Duration 0:46:59
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 0c7f483
  • Duration 0:56:51
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 0c7f483
  • Duration 1:01:19
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 0c7f483
  • Duration 1:01:54
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS 14.x

  • Commit ID: 0c7f483
  • Duration 1:15:25
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants